Uh oh!
There was an error while loading. Please reload this page.
Correct suggestions for closure arguments that need a borrow - #107306
Merged
bors merged 2 commits intoJan 28, 2023
Merged
Conversation
rustbot
commented
Jan 25, 2023
Collaborator
r? @estebank (rustbot has picked a reviewer for you, use r? to override) |
oli-obk
approved these changes
Jan 26, 2023
oli-obk
left a comment
Contributor
There was a problem hiding this comment.
r=me with either something done with the binders or commented why not
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
commented
Jan 26, 2023
Contributor
r? @oli-obk |
oli-obk
commented
Jan 26, 2023
Contributor
@bors r+ |
bors
commented
Jan 26, 2023
Collaborator
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jan 27, 2023
…losure-arg-needs-borrow, r=oli-obk Correct suggestions for closure arguments that need a borrow Fixesrust-lang#107301 by dealing with binders correctly Fixes another issue where we were suggesting adding just `&` when we expected `&mut _` in a closure arg
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 27, 2023
…losure-arg-needs-borrow, r=oli-obk Correct suggestions for closure arguments that need a borrow Fixesrust-lang#107301 by dealing with binders correctly Fixes another issue where we were suggesting adding just `&` when we expected `&mut _` in a closure arg
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107022 (Implement `SpecOptionPartialEq` for `cmp::Ordering`) - rust-lang#107100 (Use proper `InferCtxt` when probing for associated types in astconv) - rust-lang#107103 (Use new solver in `evaluate_obligation` query (when new solver is enabled)) - rust-lang#107190 (Recover from more const arguments that are not wrapped in curly braces) - rust-lang#107306 (Correct suggestions for closure arguments that need a borrow) - rust-lang#107339 (internally change regions to be covariant) - rust-lang#107344 (Minor tweaks in the new solver) - rust-lang#107373 (Don't merge vtables when full debuginfo is enabled.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Mar 25, 2023
aliemjay
commented
Mar 26, 2023
Contributor
apiraino
commented
Mar 29, 2023
Contributor
@aliemjay I assume the stable backport nomination is meant for another 1.68 point release (if it will discussed), correct (next stable 1.69.0 is due in 3 weeks)? |
apiraino
commented
Mar 30, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#107301 by dealing with binders correctly
Fixes another issue where we were suggesting adding just
&when we expected&mut _in a closure arg