') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); update ICU4X to 1.1.0 by lukas-code · Pull Request #107673 · rust-lang/rust · GitHub
Skip to content

update ICU4X to 1.1.0 - #107673

Merged
bors merged 1 commit into
rust-lang:masterfrom
lukas-code:update-icu4x
Feb 15, 2023
Merged

update ICU4X to 1.1.0#107673
bors merged 1 commit into
rust-lang:masterfrom
lukas-code:update-icu4x

Conversation

@lukas-code

@lukas-codelukas-code commented Feb 4, 2023

Copy link
Copy Markdown
Contributor

This patch updates the ICU4X crates to version 1.1.0 and regenerates the static data for rustc_baked_icu_data.

This is mostly an internal and bugfix update. It notably includes unicode-org/icu4x#2834 to fix the future compatibility warning for BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE.

full changelog

@rustbot

rustbot commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

r? @michaelwoerister

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 4, 2023
@rustbot

rustbot commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

@michaelwoerister

michaelwoerister commented Feb 6, 2023

Copy link
Copy Markdown
Member

Thanks for the PR, @lukas-code! Let's find a reviewer who knows about this part of the code.

r? @davidtwco

@davidtwco

davidtwco commented Feb 13, 2023

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 13, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 0d6fdef has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 14, 2023
@matthiaskrgr
Rollup merge ofrust-lang#107673- lukas-code:update-icu4x, r=davidtwco
0c5c12e
update ICU4X to 1.1.0
This patch updates the ICU4X crates to version 1.1.0 and regenerates the static data for `rustc_baked_icu_data`.
This is mostly an internal and bugfix update. It notably includes unicode-org/icu4x#2834 to fix the future compatibility warning for [`BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE`](rust-lang#107457).
[full changelog](https://github.com/unicode-org/icu4x/blob/icu%401.1.0/CHANGELOG.md)
@matthiaskrgrmatthiaskrgr mentioned this pull request Feb 14, 2023
Closed
@klensyklensy mentioned this pull request Feb 14, 2023
Closed
@matthiaskrgrmatthiaskrgr mentioned this pull request Feb 14, 2023
Merged
@Manishearth

Manishearth commented Feb 14, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Ddi you manually patch the pub into struct BakedDataProvider? The way to do this moving forward is what I've done in #108054, fwiw.

This is fine too, though. I can fix it later.

@lukas-code

lukas-code commented Feb 14, 2023

Copy link
Copy Markdown
ContributorAuthor

I just ran the command from the docs and didn't change the generated files.

cd compiler/rustc_baked_icu_data
rm -r src/data
icu4x-datagen -W --pretty --fingerprint --use-separate-crates --format mod -l en es fr it ja pt ru tr zh zh-Hans zh-Hant -k list/and@1 fallback/likelysubtags@1 fallback/parents@1 fallback/supplement/co@1 --cldr-tag latest --icuexport-tag latest -o src/data

icu4x-datagen -Vv is entirely unhelpful, but cargo install --list says I have v1.1.1 installed.

@Manishearth

Manishearth commented Feb 14, 2023

Copy link
Copy Markdown
Member

Ah, that's v1.1.1, I see. I was running v1.1.0

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2023
@bors
Auto merge ofrust-lang#108056- matthiaskrgr:rollup-oa6bxvh, r=matth…
0416b1a
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#107573 (Update the minimum external LLVM to 14)
- rust-lang#107626 (Fix `x fix` on the standard library itself)
- rust-lang#107673 (update ICU4X to 1.1.0)
- rust-lang#107733 (Store metrics from `metrics.json` to CI PGO timer)
- rust-lang#108007 (Use `is_str` instead of string kind comparison)
- rust-lang#108033 (add an unstable `#[rustc_coinductive]` attribute)
- rust-lang#108039 (Refactor refcounted structural_impls via functors)
- rust-lang#108040 (Use derive attributes for uninteresting traversals)
- rust-lang#108044 (interpret: rename Pointer::from_addr → from_addr_invalid)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 3549e42 into rust-lang:masterFeb 15, 2023
@rustbotrustbot added this to the 1.69.0 milestone Feb 15, 2023
@lukas-code
lukas-code deleted the update-icu4x branch February 15, 2023 12:50
@robertbastianrobertbastian mentioned this pull request Feb 17, 2023
Merged
Jarcho pushed a commit to Jarcho/rust that referenced this pull request Feb 26, 2023
@bors
Auto merge ofrust-lang#108056- matthiaskrgr:rollup-oa6bxvh, r=matth…
5a8b288
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#107573 (Update the minimum external LLVM to 14)
- rust-lang#107626 (Fix `x fix` on the standard library itself)
- rust-lang#107673 (update ICU4X to 1.1.0)
- rust-lang#107733 (Store metrics from `metrics.json` to CI PGO timer)
- rust-lang#108007 (Use `is_str` instead of string kind comparison)
- rust-lang#108033 (add an unstable `#[rustc_coinductive]` attribute)
- rust-lang#108039 (Refactor refcounted structural_impls via functors)
- rust-lang#108040 (Use derive attributes for uninteresting traversals)
- rust-lang#108044 (interpret: rename Pointer::from_addr → from_addr_invalid)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes

Assignees

@davidtwcodavidtwco

Labels

A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lukas-code@rustbot@michaelwoerister@davidtwco@bors@Manishearth