Skip to content

Rollup of 8 pull requests - #107768

Merged
bors merged 16 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-9u4cal4
Feb 8, 2023
Merged

Rollup of 8 pull requests#107768
bors merged 16 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-9u4cal4

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

WaffleLapkinand others added 16 commits February 6, 2023 09:06
LLVM 16 has moved Triple.h from ADT and into TargetParser
…u-UwU, r=cjgillot
Remove `arena_cache` modifier from `upstream_monomorphizations_for`
Arena-caching a pointer is pretty meaningless as far as I can tell.
Avoid locking the global context across the `after_expansion` callback
r? `@petrochenkov`
This was noticed in model-checking/kani#2184 (comment)
This didn't have a perf impact, as it's just an additional 2 or 3 RefCell locks being created.
…ust_fulfillment_errors, r=compiler-errors
Split fn_ctxt/adjust_fulfillment_errors from fn_ctxt/checks
This is a follow-up from rust-lang#106477, addressing a small number of the `FIXME`s that were added, by moving some functions into the new(er) `adjust_fulfillment_errors` module.
More cleanup is possible for this file (and I'll hopefully get around to doing some of that soon) but the very first thing is to just move these functions out.
There should be no "real" changes in this PR, besides minor adjustments to imports and the functions being transferred.
remove binder from query constraints
r? types
…oli-obk
miri: fix ICE when running out of address space
Fixesrust-lang/miri#2769
r? `@oli-obk`
I didn't add a test since that requires oli-obk/ui_test#38 (host must be 64bit and target 32bit). Also the test takes ~30s, so I am not sure if we want to have it in the test suite?
llvm-16: Use Triple.h from new header location.
LLVM 16 has moved Triple.h from ADT and into TargetParser.
LLVM [landed a commit](llvm/llvm-project@62c7f03) this morning moving the header. This change should make rustc continue to build against LLVM main.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 7, 2023
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=8

@bors

bors commented Feb 7, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 232213d has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2023
@bors

bors commented Feb 7, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 232213d with merge 3f059f6...

@bors

bors commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 3f059f6 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Feb 8, 2023
@bors
bors merged commit 3f059f6 into rust-lang:masterFeb 8, 2023
@rustbotrustbot added this to the 1.69.0 milestone Feb 8, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (3f059f6): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
1.7%[1.7%, 1.7%]2
Improvements ✅
(primary)
-1.0%[-1.5%, -0.4%]3
Improvements ✅
(secondary)
-3.7%[-4.2%, -3.2%]6
All ❌✅ (primary)-1.0%[-1.5%, -0.4%]3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.7%[2.2%, 3.2%]2
Improvements ✅
(primary)
-1.8%[-3.9%, -0.6%]3
Improvements ✅
(secondary)
-4.3%[-4.3%, -4.3%]1
All ❌✅ (primary)-1.8%[-3.9%, -0.6%]3

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbotrustbot added the perf-regression Performance regression. label Feb 8, 2023
@rylev

rylev commented Feb 14, 2023

Copy link
Copy Markdown
Member

Small number of regressions in secondary benchmarks in a rollup - I think we're fine calling this triaged.

@rustbot label: perf-regression-triaged

@rustbotrustbot added the perf-regression-triaged The performance regression has been triaged. label Feb 14, 2023
@matthiaskrgr
matthiaskrgr deleted the rollup-9u4cal4 branch March 16, 2024 18:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@rust-timer@rylev@rustbot@WaffleLapkin@oli-obk@Nathan-Fenner@tshepang@lcnr@RalfJung@maurer