Skip to content

Label opaque type for 'captures lifetime' error message - #108292

Merged
bors merged 2 commits into
rust-lang:masterfrom
compiler-errors:opaque-captures-where
Mar 4, 2023
Merged

Label opaque type for 'captures lifetime' error message#108292
bors merged 2 commits into
rust-lang:masterfrom
compiler-errors:opaque-captures-where

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Providing more information may help make this somewhat opaque (lol) error message a bit clearer.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 21, 2023
@rustbot

Copy link
Copy Markdown
Collaborator

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @TaKO8Ki

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sucks, but it already sucked so... 🤷

@compiler-errors

Copy link
Copy Markdown
ContributorAuthor

r? compiler

since jack said that he was going to be unavailable for a week

@rustbotrustbot assigned lcnr and unassigned jackh726Feb 22, 2023
@compiler-errors

compiler-errors commented Feb 22, 2023

Copy link
Copy Markdown
ContributorAuthor

lcnr has too many of my prs already 🤣

r? @oli-obk

@rustbotrustbot assigned oli-obk and unassigned lcnrFeb 22, 2023
@bors

bors commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #103042) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit bdacc8b has been approved by oli-obk

It is now in the queue for this repository.

@bors

bors commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 3, 2023
…ere, r=oli-obk
Label opaque type for 'captures lifetime' error message
Providing more information may help make this somewhat opaque (lol) error message a bit clearer.
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2023
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#104549 (add -Zexport-executable-symbols to unstable book)
- rust-lang#108292 (Label opaque type for 'captures lifetime' error message)
- rust-lang#108540 (Add `Atomic*::from_ptr`)
- rust-lang#108634 (Add link to component dashboard)
- rust-lang#108647 (Remove dead pgo.sh file)
- rust-lang#108678 (Use `Option::as_slice` where applicable)
- rust-lang#108681 (Improve comments in `needs_process_obligation`.)
- rust-lang#108688 (Match unmatched backticks in library/)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 188ed14 into rust-lang:masterMar 4, 2023
@rustbotrustbot added this to the 1.69.0 milestone Mar 4, 2023
@compiler-errors
compiler-errors deleted the opaque-captures-where branch August 11, 2023 20:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@compiler-errors@rustbot@bors@oli-obk@lcnr@jackh726