Skip to content

Exit when there are unmatched delims to avoid noisy diagnostics - #108297

Merged
bors merged 5 commits into
rust-lang:masterfrom
chenyukang:yukang/delim-error-exit
Mar 1, 2023
Merged

Exit when there are unmatched delims to avoid noisy diagnostics#108297
bors merged 5 commits into
rust-lang:masterfrom
chenyukang:yukang/delim-error-exit

Conversation

@chenyukang

@chenyukangchenyukang commented Feb 21, 2023

Copy link
Copy Markdown
Member

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 21, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed Feb 21, 2023
View reviewed changes
Comment threadcompiler/rustc_parse/src/lexer/tokentrees.rs Outdated
Comment threadcompiler/rustc_parse/src/lib.rs Outdated
Comment threadcompiler/rustc_parse/src/lib.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2023
@chenyukang
chenyukangforce-pushed the yukang/delim-error-exit branch 4 times, most recently from 297d57a to 84f8f03CompareFebruary 22, 2023 07:00
@chenyukang

chenyukang commented Feb 22, 2023

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 22, 2023
@chenyukang
chenyukangforce-pushed the yukang/delim-error-exit branch from 4b5fc87 to 2176d5bCompareFebruary 22, 2023 11:11
@bors

This comment was marked as resolved.

Sign in to view
@chenyukang
chenyukangforce-pushed the yukang/delim-error-exit branch from 2176d5b to 83297e1CompareFebruary 23, 2023 01:31
petrochenkov
petrochenkov reviewed Feb 27, 2023
View reviewed changes
Comment threadcompiler/rustc_parse/src/lexer/tokentrees.rs Outdated
Comment threadcompiler/rustc_parse/src/lexer/tokentrees.rs Outdated
Comment threadcompiler/rustc_parse/src/lib.rs Outdated

@petrochenkovpetrochenkovFeb 27, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Parser::unclosed_delims field ever populated after this change?

@chenyukangchenyukangFeb 28, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but this field is used in parser itself, I found that we could have more cleanup on Parser::unclosed_delims, maybe it's better to do it in another Pr.

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2023
@chenyukang
chenyukangforce-pushed the yukang/delim-error-exit branch from 83297e1 to a62fb55CompareFebruary 28, 2023 03:04
@petrochenkovpetrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2023
@chenyukang
chenyukangforce-pushed the yukang/delim-error-exit branch from a62fb55 to f808877CompareFebruary 28, 2023 07:57
@chenyukang

chenyukang commented Feb 28, 2023

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@petrochenkov

petrochenkov commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit f808877 has been approved by petrochenkov

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 28, 2023
@matthiaskrgr
Rollup merge ofrust-lang#108297- chenyukang:yukang/delim-error-exit…
d33bbfd
…, r=petrochenkov
Exit when there are unmatched delims to avoid noisy diagnostics
From rust-lang#104012 (comment)
r? `@petrochenkov`
@matthiaskrgrmatthiaskrgr mentioned this pull request Feb 28, 2023
Closed
@matthiaskrgrmatthiaskrgr mentioned this pull request Mar 1, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2023
@bors
Auto merge ofrust-lang#108586- matthiaskrgr:rollup-ry9u2ou, r=matth…
5983a3a
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#108297 (Exit when there are unmatched delims to avoid noisy diagnostics)
- rust-lang#108531 (rustdoc: Show that repeated expression arrays can be made with constant values)
- rust-lang#108536 (Update books)
- rust-lang#108550 (Remove the `capture_disjoint_fields` feature)
- rust-lang#108551 (Descriptive error when users try to combine RPITIT/AFIT with specialization)
- rust-lang#108554 (Only look for param in item's generics if it actually comes from generics)
- rust-lang#108555 (Fix a race in the query system)
- rust-lang#108558 (add missing feature in core/tests)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 371904b into rust-lang:masterMar 1, 2023
@rustbotrustbot added this to the 1.69.0 milestone Mar 1, 2023
@chenyukangchenyukang mentioned this pull request Mar 1, 2023
Merged
This was referenced Mar 1, 2023
Closed
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2023
@matthiaskrgr
Rollup merge ofrust-lang#108606- chenyukang:yukang/fix-104367, r=co…
c09a9a6
…mpiler-errors
Add test case for mismatched open/close delims
Fixesrust-lang#104367Fixesrust-lang#105209
After landing rust-lang#108297, these issues are resolved.
This was referenced Mar 3, 2023
Closed
Closed
Closed
@chenyukangchenyukang mentioned this pull request Mar 3, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2023
@matthiaskrgr
Rollup merge ofrust-lang#108715- chenyukang:yukang/cleanup-parser-d…
223e47c
…elims, r=compiler-errors
Remove unclosed_delims from parser
After landing rust-lang#108297
we could remove `unclosed_delims` from the parser now.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2023
@matthiaskrgr
Rollup merge ofrust-lang#108715- chenyukang:yukang/cleanup-parser-d…
dd6f03d
…elims, r=compiler-errors
Remove unclosed_delims from parser
After landing rust-lang#108297
we could remove `unclosed_delims` from the parser now.
@fmeasefmease mentioned this pull request Oct 6, 2023
Closed
@jrudermanjruderman mentioned this pull request Nov 6, 2023
Closed
@chenyukangchenyukang mentioned this pull request Feb 14, 2025
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 15, 2025
@jhpratt
Rollup merge ofrust-lang#137029- chenyukang:yukang-fix-unused-check…
221ba2d
…, r=jieyouxu,compiler-errors
Remove unnecessary check code in unused_delims
After PR rust-lang#108297, we make sure there is no unmatched delims in early lint check.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2025
@rust-timer
Unrolled build forrust-lang#137029
d450a6e
Rollup merge of rust-lang#137029 - chenyukang:yukang-fix-unused-check, r=jieyouxu,compiler-errors
Remove unnecessary check code in unused_delims
After PR rust-lang#108297, we make sure there is no unmatched delims in early lint check.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

5 participants

@chenyukang@rust-log-analyzer@bors@petrochenkov@rustbot