Skip to content

Allow setting hashmap toml values in ./configure - #108644

Merged
bors merged 1 commit into
rust-lang:masterfrom
KittyBorgX:hashmap-toml
Mar 3, 2023
Merged

Allow setting hashmap toml values in ./configure#108644
bors merged 1 commit into
rust-lang:masterfrom
KittyBorgX:hashmap-toml

Conversation

@KittyBorgX

@KittyBorgXKittyBorgX commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

Fixes#108621

@rustbot

rustbot commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 2, 2023
@albertlarsan68

albertlarsan68 commented Mar 2, 2023

Copy link
Copy Markdown
Member

This doesn't do the right thing, here is a quick replacement you can inspire from:

"{"+", ".join(map(lambdaa: "{} = {}".format(to_toml(a[0]), to_toml(a[1])), value.items())) +"}"

@KittyBorgX

KittyBorgX commented Mar 2, 2023

Copy link
Copy Markdown
ContributorAuthor

This doesn't do the right thing, here is a quick replacement you can inspire from:

"{"+", ".join(map(lambdaa: "{} = {}".format(to_toml(a[0]), to_toml(a[1])), value.items())) +"}"

Thank you so much!
I'm just curious : My code emmited build-config = {'LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN' = 'YES'} too, what was the mistake with it?

@albertlarsan68

albertlarsan68 commented Mar 2, 2023

Copy link
Copy Markdown
Member

to_toml({"a": "5", "b": "A"}) produced {'a', 'b'=5,'A'}, which is not valid.
Do you understand the difference between the old and the new?

@KittyBorgX

KittyBorgX commented Mar 2, 2023

Copy link
Copy Markdown
ContributorAuthor

to_toml({"a": "5", "b": "A"}) produced {'a', 'b'=5,'A'}, which is not valid. Do you understand the difference between the old and the new?

I hadn't given it much thought till now, I replicated a few examples and understood the difference 😅

@albertlarsan68

albertlarsan68 commented Mar 2, 2023

Copy link
Copy Markdown
Member

Thanks for the PR!
@bors r+ rollup

@bors

bors commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit a6580ba has been approved by albertlarsan68

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Mar 2, 2023
@compiler-errors
Rollup merge ofrust-lang#108644- KittyBorgX:hashmap-toml, r=albertl…
c897cbe
…arsan68
Allow setting hashmap toml values in `./configure`
Fixesrust-lang#108621
@compiler-errorscompiler-errors mentioned this pull request Mar 2, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2023
@matthiaskrgr
Rollup merge ofrust-lang#108644- KittyBorgX:hashmap-toml, r=albertl…
5acde60
…arsan68
Allow setting hashmap toml values in `./configure`
Fixesrust-lang#108621
@matthiaskrgrmatthiaskrgr mentioned this pull request Mar 2, 2023
Closed
@matthiaskrgrmatthiaskrgr mentioned this pull request Mar 2, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2023
@bors
Auto merge ofrust-lang#108677- matthiaskrgr:rollup-i91cxuf, r=matth…
7a809ce
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#108022 (Support allocations with non-Box<[u8]> bytes)
- rust-lang#108367 (Re-apply "switch to the macos-12-xl builder")
- rust-lang#108557 (Point error span at Some constructor argument when trait resolution fails)
- rust-lang#108573 (Explain compile-time vs run-time difference in env!() error message)
- rust-lang#108584 (Put backtick content from rustdoc search errors into a `<code>` elements)
- rust-lang#108624 (Make `ExprKind` the first field in `thir::Expr`)
- rust-lang#108644 (Allow setting hashmap toml values in `./configure`)
- rust-lang#108672 (Feed queries on impl side for RPITITs when using lower_impl_trait_in_trait_to_assoc_ty)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 8a21bce into rust-lang:masterMar 3, 2023
@rustbotrustbot added this to the 1.69.0 milestone Mar 3, 2023
@KittyBorgX
KittyBorgX deleted the hashmap-toml branch March 7, 2023 13:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@albertlarsan68albertlarsan68

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

./configure doesn't allow setting hashmap toml values

4 participants

@KittyBorgX@rustbot@albertlarsan68@bors