Skip to content

Rustdoc search: Emit an error for unclosed generic - #108656

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:rustdoc-search-unclosed-generic
Mar 4, 2023
Merged

Rustdoc search: Emit an error for unclosed generic#108656
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:rustdoc-search-unclosed-generic

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Mar 2, 2023

Copy link
Copy Markdown
Member

Now, search like a< will error as it should (and as written in the eBNF).

r? @notriddle

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 2, 2023
@rustbot

rustbot commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@notriddle

notriddle commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 892d73d has been approved by notriddle

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 3, 2023
@matthiaskrgr
Rollup merge ofrust-lang#108656- GuillaumeGomez:rustdoc-search-uncl…
97280be
…osed-generic, r=notriddle
Rustdoc search: Emit an error for unclosed generic
Now, search like `a<` will error as it should (and as written in the eBNF).
r? `@notriddle`
@matthiaskrgrmatthiaskrgr mentioned this pull request Mar 3, 2023
Closed
@matthiaskrgr

matthiaskrgr commented Mar 3, 2023

Copy link
Copy Markdown
Member

Hmm might have failed in a rollup, but I'm not seeing how tbh

 Testing filter-crate.js ... OK
Testing fn-forget.js ... OK
Testing from_u.js ... OK
Testing keyword.js ... OK
Testing macro-check.js ... OK
Testing macro-print.js ... OK
Testing never.js ... OK
/checkout/src/tools/rustdoc-js/tester.js:143
result_v.forEach((value, index) => {
^
TypeError: result_v.forEach is not a function
at valueCheck (/checkout/src/tools/rustdoc-js/tester.js:143:26)
at runParser (/checkout/src/tools/rustdoc-js/tester.js:170:9)
at /checkout/src/tools/rustdoc-js/tester.js:306:20
at runCheck (/checkout/src/tools/rustdoc-js/tester.js:256:30)
at runChecks (/checkout/src/tools/rustdoc-js/tester.js:305:16)
at /checkout/src/tools/rustdoc-js/tester.js:426:23
at Array.forEach (<anonymous>)
at main (/checkout/src/tools/rustdoc-js/tester.js:421:45)
at Object.<anonymous> (/checkout/src/tools/rustdoc-js/tester.js:433:14)
at Module._compile (internal/modules/cjs/loader.js:999:30)
Testing parser-errors.js ... Build completed unsuccessfully in 0:27:51

https://github.com/rust-lang-ci/rust/actions/runs/4326491891/jobs/7553984409#step:26:36168

please just disregard and rer+ if its spurious or I'm wrong 🙈

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2023
@GuillaumeGomez

GuillaumeGomez commented Mar 3, 2023

Copy link
Copy Markdown
MemberAuthor

No, it's definitely linked. I'll check if it's because of a missing rebase or another PR in the rollup.

@GuillaumeGomez
GuillaumeGomezforce-pushed the rustdoc-search-unclosed-generic branch from 892d73d to 8236715CompareMarch 3, 2023 19:49
@GuillaumeGomez

GuillaumeGomez commented Mar 3, 2023

Copy link
Copy Markdown
MemberAuthor

It was a missing rebase.

@notriddle

notriddle commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 8236715 has been approved by notriddle

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2023
@Dylan-DPCDylan-DPC mentioned this pull request Mar 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2023
@bors
Auto merge ofrust-lang#108732- Dylan-DPC:rollup-dy1l8sx, r=Dylan-DPC
276b75a
Rollup of 6 pull requests
Successful merges:
- rust-lang#108298 (Fix ICE: check if snippet is `)`)
- rust-lang#108405 (Lazily compute crate name for consider_optimizing)
- rust-lang#108656 (Rustdoc search: Emit an error for unclosed generic)
- rust-lang#108660 (Remove ne implementations from strings)
- rust-lang#108669 (Allow checking whether a type allows being uninitialized)
- rust-lang#108727 (rustc_expand: make proc-macro derive error translatable)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 2fc4935 into rust-lang:masterMar 4, 2023
@rustbotrustbot added this to the 1.69.0 milestone Mar 4, 2023
@GuillaumeGomez
GuillaumeGomez deleted the rustdoc-search-unclosed-generic branch March 4, 2023 15:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@notriddlenotriddle

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez@rustbot@notriddle@bors@matthiaskrgr