Match unmatched backticks in compiler/ by est31 · Pull Request #108685 · rust-lang/rust

est31 · 2023-03-03T00:51:58Z

Found with GNU grep:

grep -rEn '^(([^`]*`){2})*[^`]*`[^`]*$' compiler/ | rg -v '\s*[//]?.{1,2}```'

rustbot · 2023-03-03T00:52:04Z

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-03-03T00:52:08Z

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

est31 · 2023-03-03T01:02:50Z

These two I don't know what to put:

rust/compiler/rustc_hir_typeck/src/closure.rs

Line 401 in 13471d3

/// - S would be `fn(&u32) ->

rust/compiler/rustc_trait_selection/src/solve/assembly.rs

Line 250 in 13471d3

/// this case as projections as self types add `

rustbot · 2023-03-03T01:35:43Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

saethlin · 2023-03-03T02:01:04Z

I think you should split out the library diff into a separate PR, based on this topic: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Spelling.20is.20style.3F/near/328759605

est31 · 2023-03-03T02:15:34Z

@saethlin I think the concerns were mostly about PRs, many of which very low effort, that were extremely huge and offloaded the reviewing of the tool to the PR reviewer. They had questionable quality, and sometimes it was questionable if they were improvements at all. Here the improvement is tiny, but very clear. It should be easy to review it. I just saw an error message with an unmatched when working on #108682, ` and then wondered about other occurrences of the character in the code.

This PR isn't just changing comments, it's also changing error messages of different kinds (both diagnostics and ICE messages).

est31 · 2023-03-03T03:36:04Z

Okay reading through the thread of #58619, changes that only change rustc-internal comments aren't really liked, but if they are small in size, or easy to review they might still be accepted. Changes to public facing features/docs are still definitely wanted, even if cosmetic.

I've split up this PR into multiple commits:

"Match end user facing unmatched backticks in compiler/" should be the least controversial. I see ICE messages, diagnostic messages, and lint documentation that gets rendered to the rustc mdbook (from my understanding, correct me if I'm wrong) as end user facing.
"Match unmatched backticks in compiler/ that are part of rustdoc" concerns changes to the rustdoc that is rendered to the publicly available rustc-internal rustdoc. Those are rustc developer facing changes.
"Match unmatched backticks in comments in compiler/" touches non-rustdoc comments only, that are only read by people who have directly opened the file (instead of browsing the rustdoc). This is probably the most controversial of the bunch.
"Rustdoc-ify LiteralKind note" turns a // comment into a rustdoc comment, as well as adjusts an unmatched backtick to use ""s as is done in the surrounding rustdocs. Explicitly wanted.
"Don't put integers into backticks during formatting" addresses @saethlin 's comments from above.

The commits have differing levels of controversialness. Please tell me which ones are not wanted and I should remove, and which ones I should put into different PRs. Thanks!

est31 · 2023-03-03T03:47:31Z

Alright I have removed the commit that only changed the comments. I don't agree with the policy, and it might not actually be unwanted by that policy, but ultimately it's a choice I have to respect. Now all the changes should be non-controversial ones, I hope.

Noratrieb · 2023-03-03T06:00:57Z

You can make a separate PR with the compiler comments and add me or @WaffleLapkin as the reviewer, we're fine with reviewing it.

est31 · 2023-03-03T07:34:04Z

Alright, I have removed even the rustdoc changes from this PR (outside of the one commit about LiteralKind) and moved the two into #108694. Sorry for all the noise, I hope now it should be easy enough to review the patches.

petrochenkov · 2023-03-03T09:26:15Z

Changes in this PR are certainly not in the same category (and amount) as in PRs that motivated #58619.
Missing left or right quotes a obviously typos/mistakes.
@bors r+

bors · 2023-03-03T09:26:19Z

📌 Commit c54f061 has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2023-03-03T09:26:20Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

…rochenkov Match unmatched backticks in compiler/ Found with GNU grep: ``` grep -rEn '^(([^`]*`){2})*[^`]*`[^`]*$' compiler/ | rg -v '\s*[//]?.{1,2}```' ```

…ts, r=Nilstrieb Match unmatched backticks in compiler/ comments r? `@Nilstrieb` as per [advice](rust-lang#108685 (comment))

…y, r=jyn514 Match unmatched backticks in library/ Found with GNU grep: ``` grep -rEn '^(([^`]*`){2})*[^`]*`[^`]*$' library/ | rg -v '\s*[//]?.{1,2}```' ``` split out from rust-lang#108685 as per advice.

…ts, r=Nilstrieb Match unmatched backticks in compiler/ comments r? ``@Nilstrieb`` as per [advice](rust-lang#108685 (comment))

…y, r=jyn514 Match unmatched backticks in library/ Found with GNU grep: ``` grep -rEn '^(([^`]*`){2})*[^`]*`[^`]*$' library/ | rg -v '\s*[//]?.{1,2}```' ``` split out from rust-lang#108685 as per advice.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#107981 (new solver: implement canonicalization and region constraints) - rust-lang#108553 (Deny capturing late-bound non-lifetime param in anon const) - rust-lang#108599 (Remove legacy PM leftovers) - rust-lang#108667 (Fix another ICE in `point_at_expr_source_of_inferred_type`) - rust-lang#108674 (Clippy Fix array-size-threshold config deserialization error) - rust-lang#108685 (Match unmatched backticks in compiler/) - rust-lang#108694 (Match unmatched backticks in compiler/ comments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned petrochenkov Mar 3, 2023

saethlin reviewed Mar 3, 2023
View reviewed changes

Comment threadcompiler/rustc_const_eval/src/interpret/intrinsics.rs Outdated

saethlin reviewed Mar 3, 2023
View reviewed changes

Comment threadcompiler/rustc_mir_transform/src/lower_slice_len.rs Outdated

est31 force-pushed the backticks_matchmaking branch from 779bb67 to 029ea8fCompare March 3, 2023 01:24

saethlin reviewed Mar 3, 2023
View reviewed changes

Comment threadlibrary/std/src/sys_common/wtf8.rs Outdated

saethlin reviewed Mar 3, 2023
View reviewed changes

Comment threadlibrary/std/src/sys_common/net/tests.rs Outdated

est31 mentioned this pull request Mar 3, 2023
Match unmatched backticks in library/ #108688
Merged

est31 force-pushed the backticks_matchmaking branch 3 times, most recently from dc637b8 to 3d87a83Compare March 3, 2023 03:27

est31 changed the title ~~Match unmatched backticks~~Match unmatched backticks in compiler/Mar 3, 2023

est31 force-pushed the backticks_matchmaking branch from 3d87a83 to 00be991Compare March 3, 2023 03:45

est31 mentioned this pull request Mar 3, 2023
Match unmatched backticks in compiler/ comments #108694
Merged

est31 force-pushed the backticks_matchmaking branch from 00be991 to c656a34Compare March 3, 2023 07:32

est31 added 3 commits March 3, 2023 08:39

Match end user facing unmatched backticks in compiler/
ef65890

Rustdoc-ify LiteralKind note
5a02105

Don't put integers into backticks during formatting
c54f061

est31 force-pushed the backticks_matchmaking branch from c656a34 to c54f061Compare March 3, 2023 07:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2023

matthiaskrgr mentioned this pull request Mar 3, 2023
Rollup of 8 pull requests #108701
Closed

matthiaskrgr mentioned this pull request Mar 3, 2023
Rollup of 7 pull requests #108707
Merged

bors merged commit 846424d into rust-lang:masterMar 3, 2023

rustbot added this to the 1.69.0 milestone Mar 3, 2023

est31 mentioned this pull request Mar 8, 2023
tidy: enforce comment blocks to have an even number of backticks #108726
Merged

Uh oh!

Uh oh!

Conversation

est31 commented Mar 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 3, 2023

Uh oh!

rustbot commented Mar 3, 2023

Uh oh!

est31 commented Mar 3, 2023

Uh oh!

Uh oh!

Uh oh!

rustbot commented Mar 3, 2023

Uh oh!

Uh oh!

Uh oh!

saethlin commented Mar 3, 2023

Uh oh!

est31 commented Mar 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

est31 commented Mar 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

est31 commented Mar 3, 2023

Uh oh!

Noratrieb commented Mar 3, 2023

Uh oh!

est31 commented Mar 3, 2023

Uh oh!

petrochenkov commented Mar 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Mar 3, 2023

Uh oh!

bors commented Mar 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

est31 commented Mar 3, 2023•
edited
Loading

est31 commented Mar 3, 2023•
edited
Loading

est31 commented Mar 3, 2023•
edited
Loading

petrochenkov commented Mar 3, 2023•
edited
Loading