Remove NormalizationError::ConstantKind

[compiler-errors]

No longer in use by TryNormalizeAfterErasingRegionsFolder (as of #102355 / e8150fa it seems). It's making LayoutError, etc. kinda large -- that was noticed by @Zoxc.

[rustbot]

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit a43b554 with merge 45ef8287e0460e0232c84651df5dcaf16b0daf82...

[lcnr]

r=me after perf

[bors]

☀️ Try build successful - checks-actions
Build commit: 45ef8287e0460e0232c84651df5dcaf16b0daf82 (45ef8287e0460e0232c84651df5dcaf16b0daf82)

[bors]

☀️ Try build successful - checks-actions
Build commit: 45ef8287e0460e0232c84651df5dcaf16b0daf82 (45ef8287e0460e0232c84651df5dcaf16b0daf82)

[rust-timer]

Finished benchmarking commit (45ef8287e0460e0232c84651df5dcaf16b0daf82): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-0.9%, -0.9%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[3.6%, 3.6%]	1
Regressions ❌ (secondary)	2.3%	[0.9%, 3.1%]	3
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	1.0%	[-1.5%, 3.6%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	1
All ❌✅ (primary)	-	-	0

[lcnr]

@bors r+

[bors]

📌 Commit a43b554 has been approved by lcnr

It is now in the queue for this repository.

[bors]

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

[bors]

⌛ Testing commit a43b554 with merge 01b7a6a...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 01b7a6a to master...

[rust-timer]

Finished benchmarking commit (01b7a6a): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.0%, 1.1%]	2
Regressions ❌ (secondary)	2.3%	[2.1%, 2.7%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.6%, -0.6%]	1
All ❌✅ (primary)	1.1%	[1.0%, 1.1%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-3.3%, -1.2%]	2
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-2.3%	[-3.3%, -1.2%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

[lqd]

I believe this is just more keccak and cranelift-codegen noise.

@rustbot label: +perf-regression-triaged