Uh oh!
There was an error while loading. Please reload this page.
Embed Windows application manifests - #10878
Conversation
There was a problem hiding this comment.
Is it possible to just do this as a literal:
"<?xml version='1.0' encoding='UTF-8' standalone='yes'?>\r<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>\r <trustInfo xmlns='urn:schemas-microsoft-com:asm.v3'>\r..."?
There was a problem hiding this comment.
concat!() performs compile-time concatenation, so this is a single literal.
There was a problem hiding this comment.
I know that, I was talking at a source level because it just seems a little peculiar to have 10 strings rather than 1 (and concat! will possibly be removed, because it is designed to allow things like concat!("foo", some_macro!()) rather than just plain strings, and this "local expansion" can cause problems with hygiene, apparently.)
alexcrichton
commented
Dec 9, 2013
silly windows, but nice work! |
vadimcn
commented
Dec 9, 2013
@alexcrichton: moved manifest stuff to a separate file, added comments as you asked. r? |
alexcrichton
commented
Dec 10, 2013
Needs a rebase. |
vadimcn
commented
Dec 10, 2013
@alexcrichton: Rebased |
alexcrichton
commented
Dec 10, 2013
It appears some rebasing indentation has gone wrong. While you're at it, could you rebase these into a single commit? |
vadimcn
commented
Dec 10, 2013
Done. |
vadimcn
commented
Dec 12, 2013
@alexcrichton: retry ...please :) |
vadimcn
commented
Dec 12, 2013
Grrr... this trailing whitespace check is infuriating. Also, rebased |
vadimcn
commented
Dec 13, 2013
I can't fathom how could this have broken Android but not other unixes... Perhaps a spurious build machine error? |
In order to avoid UAC installer detection silliness... Closes#10512
…et,GuillaumeGomez Allow more attributes in `clippy::useless_attribute` Fixesrust-lang#12753Fixesrust-lang#4467Fixesrust-lang#11595Fixesrust-lang#10878 changelog: [`useless_attribute`]: Attributes allowed on `use` items now include `ambiguous_glob_exports`, `hidden_glob_reexports`, `dead_code`, `unused_braces`, and `clippy::disallowed_types`.
10951: feat: assist to generate documentation templates r=Veykril a=numero-744 Closesrust-lang#10878, rust-lang#1915 and rust-lang#4767 Full description is in rust-lang#10878, better read [the tests](https://github.com/rust-analyzer/rust-analyzer/pull/10951/files#diff-7a64e2efb66b2625443340fcbc96d531baff12c17cc0aaf51885ea94f67de254R424) to understand what this feature does. - [x] There is one remaining thing about non-`pub` functions, what do you think about it? - [x] In this PR [empty examples are generated](https://github.com/rust-analyzer/rust-analyzer/pull/10951/files#diff-7a64e2efb66b2625443340fcbc96d531baff12c17cc0aaf51885ea94f67de254R99) for `trait` functions, but maybe no examples should be provided at all. - [x] If there is already a documentation, add another one with a separator ([currently done](https://github.com/rust-analyzer/rust-analyzer/pull/10951/files#diff-7a64e2efb66b2625443340fcbc96d531baff12c17cc0aaf51885ea94f67de254R74)) or simply disable this assist? - [x] I will check once more that the generated examples are correct (ie. they are easy to fill before that they are built and tested) Comments appreciated 😄 Co-authored-by: Côme ALLART <come.allart@etu.emse.fr>
In order to avoid UAC installer detection silliness...
Closes#10512