Skip to content

rustdoc: reduce allocations in visibility_to_src_with_space - #109283

Merged
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/visibility-to-src-with-space
Mar 18, 2023
Merged

rustdoc: reduce allocations in visibility_to_src_with_space#109283
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/visibility-to-src-with-space

Conversation

@notriddle

Copy link
Copy Markdown
Contributor

No description provided.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 17, 2023
@klensy

Copy link
Copy Markdown
Contributor

Isn't visibility_to_src_with_space it?

@notriddle

Copy link
Copy Markdown
ContributorAuthor

Yes 🤦 thanks.

@notriddle
notriddleforce-pushed the notriddle/visibility-to-src-with-space branch from 4e30fab to 8628e27CompareMarch 17, 2023 22:43
@notriddlenotriddle changed the title rustdoc: reduce allocations in visibility_print_with_spacerustdoc: reduce allocations in visibility_to_src_with_spaceMar 17, 2023
@jsha

jsha commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

Looks good. r=me once tests pass.

@notriddle

Copy link
Copy Markdown
ContributorAuthor

@bors r=jsha rollup

@bors

bors commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 8628e27 has been approved by jsha

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2023
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#107416 (Error code E0794 for late-bound lifetime parameter error.)
- rust-lang#108772 (Speed up tidy quite a lot)
- rust-lang#109193 (Add revisions for -Zlower-impl-trait-in-trait-to-assoc-ty fixed tests)
- rust-lang#109234 (Tweak implementation of overflow checking assertions)
- rust-lang#109238 (Fix generics mismatch errors for RPITITs on -Zlower-impl-trait-in-trait-to-assoc-ty)
- rust-lang#109283 (rustdoc: reduce allocations in `visibility_to_src_with_space`)
- rust-lang#109287 (Use `size_of_val` instead of manual calculation)
- rust-lang#109288 (Stabilise `unix_socket_abstract`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit e81a072 into rust-lang:masterMar 18, 2023
@rustbotrustbot added this to the 1.70.0 milestone Mar 18, 2023
@notriddle
notriddle deleted the notriddle/visibility-to-src-with-space branch March 18, 2023 15:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@notriddle@rustbot@klensy@jsha@bors