Skip to content

Rollup of 8 pull requests - #109652

Merged
bors merged 17 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-pbw3hi3
Mar 27, 2023
Merged

Rollup of 8 pull requests#109652
bors merged 17 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-pbw3hi3

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

mattfbaconand others added 17 commits June 28, 2022 17:01
It is no longer necessary as __rust_start_panic switched to the Rust abi.
…out_of
This avoids some type interning and a query execution. It also just
makes the code simpler.
…rom-raw-parts, r=m-ou-se,the8472
Stabilize `nonnull_slice_from_raw_parts`
FCP is done: rust-lang#71941 (comment)
Note that this doesn't const-stabilize `NonNull::slice_from_raw_parts` as `slice_from_raw_parts_mut` isn't const-stabilized yet. Given rust-lang#67456 and rust-lang#57349, it's not likely available soon, meanwhile, stabilizing only the feature makes some sense, I think.
Closesrust-lang#71941
Follow C-RW-VALUE in std::io::Cursor example
rustc-dev-guide says to do this:
r? ``@steveklabnik``
…=ChrisDenton
Remove unnecessary raw pointer in __rust_start_panic arg
It is no longer necessary as __rust_start_panic switched to the Rust abi.
…=Nilstrieb
Use an IndexVec to debug fingerprints.
Uncontroversial part of rust-lang#109050
…stion, r=compiler-errors
fix type suggestions in match arms
fixrust-lang#109586
…ing, r=notriddle
Fix "Directly go to item in search if there is only one result" setting
Part of rust-lang#66181.
The setting was actually broken, so I fixed it when I added the GUI test.
r? `@notriddle`
…=errors
debuginfo: Get pointer size/align from tcx.data_layout instead of layout_of
This avoids some type interning and a query execution. It also just makes the code simpler.
…-obl, r=oli-obk
Don't elaborate non-obligations into obligations
It's suspicious to elaborate a `PolyTraitRef` or `Predicate` into an `Obligation`, since the former does not have a param-env associated with it, but the latter does. This is a footgun that, while not being misused *currently* in the compiler, easily could be misused by someone less familiar with the elaborator's inner workings.
This PR just changes the API -- ideally, the elaborator wouldn't even have to deal with obligations if we're not elaborating obligations, but that would require a bit more abstraction than I could be bothered with today.
@rustbotrustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Mar 27, 2023
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=8

@bors

bors commented Mar 27, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 6535e66 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2023
@bors

bors commented Mar 27, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6535e66 with merge 553ecbe...

@bors

bors commented Mar 27, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 553ecbe to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Mar 27, 2023
@bors
bors merged commit 553ecbe into rust-lang:masterMar 27, 2023
@rustbotrustbot added this to the 1.70.0 milestone Mar 27, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (553ecbe): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
1.2%[1.2%, 1.2%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)1.2%[1.2%, 1.2%]1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
1.0%[1.0%, 1.0%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)1.0%[1.0%, 1.0%]1

@matthiaskrgr
matthiaskrgr deleted the rollup-pbw3hi3 branch March 16, 2024 18:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@matthiaskrgr@bors@rust-timer@rustbot@mattfbacon@JohnTitor@cjgillot@GuillaumeGomez@bjorn3@Noratrieb@compiler-errors