Skip to content

tidy: Issue an error when UI test limits are too high - #110241

Merged
bors merged 1 commit into
rust-lang:masterfrom
clubby789:tidy-reduce-limit
Apr 12, 2023
Merged

tidy: Issue an error when UI test limits are too high#110241
bors merged 1 commit into
rust-lang:masterfrom
clubby789:tidy-reduce-limit

Conversation

@clubby789

Copy link
Copy Markdown
Contributor

cc #73494
Ensuring the limits are as low as they need to be will make it harder to accidentally add new tests to any large directories

@rustbot

Copy link
Copy Markdown
Collaborator

r? @ozkanonur

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 12, 2023
@albertlarsan68

Copy link
Copy Markdown
Member

r? @albertlarsan68Thanks for the PR!
@bors r+

@bors

bors commented Apr 12, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit e0ed174 has been approved by albertlarsan68

It is now in the queue for this repository.

@rustbot

Copy link
Copy Markdown
Collaborator

Failed to set assignee to albertlarsan68Thanks: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2023
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#110153 (Fix typos in compiler)
- rust-lang#110165 (rustdoc: use CSS `overscroll-behavior` instead of JavaScript)
- rust-lang#110175 (Symbol cleanups)
- rust-lang#110203 (Remove `..` from return type notation)
- rust-lang#110205 (rustdoc: make settings radio and checks thicker, less contrast)
- rust-lang#110222 (Improve the error message when forwarding a matched fragment to another macro)
- rust-lang#110237 (Split out a separate feature gate for impl trait in associated types)
- rust-lang#110241 (tidy: Issue an error when UI test limits are too high)
Failed merges:
- rust-lang#110218 (Remove `ToRegionVid`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4844164 into rust-lang:masterApr 12, 2023
@rustbotrustbot added this to the 1.70.0 milestone Apr 12, 2023
@clubby789
clubby789 deleted the tidy-reduce-limit branch April 13, 2023 00:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@clubby789@rustbot@albertlarsan68@bors@onur-ozkan