Skip to content

Suggest using integration tests for test crate using own proc-macro - #110255

Merged
bors merged 1 commit into
rust-lang:masterfrom
clubby789:proc-macro-test-help
Apr 24, 2023
Merged

Suggest using integration tests for test crate using own proc-macro#110255
bors merged 1 commit into
rust-lang:masterfrom
clubby789:proc-macro-test-help

Conversation

@clubby789

Copy link
Copy Markdown
Contributor

@rustbot

Copy link
Copy Markdown
Collaborator

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 12, 2023
@clubby789clubby789 changed the title Suggest using integration tests for proc-macrosSuggest using integration tests for test crate using own proc-macroApr 12, 2023
@jackh726

Copy link
Copy Markdown
Member

This needs a test. Not exactly sure the best way to write one.

@clubby789
clubby789force-pushed the proc-macro-test-help branch from 1aa85ce to f7581d8CompareApril 17, 2023 12:01
@clubby789

Copy link
Copy Markdown
ContributorAuthor

Added a test

@jackh726

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit f7581d8 has been approved by jackh726

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 23, 2023
…jackh726
Suggest using integration tests for test crate using own proc-macro
cc rust-lang#110247
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2023
…jackh726
Suggest using integration tests for test crate using own proc-macro
cc rust-lang#110247
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2023
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#110255 (Suggest using integration tests for test crate using own proc-macro)
- rust-lang#110514 (Remove `find_map_relevant_impl`)
- rust-lang#110566 (Don't create projection ty for const projection)
- rust-lang#110637 (Group some sections of our logs in github actions)
- rust-lang#110706 (Add `intrinsics::transmute_unchecked`)
- rust-lang#110714 (Normalize types and consts in MIR opts.)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0f27161 into rust-lang:masterApr 24, 2023
@rustbotrustbot added this to the 1.71.0 milestone Apr 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@clubby789@rustbot@jackh726@bors