Skip to content

Update documentation wording on path 'try_exists' functions - #110266

Merged
bors merged 1 commit into
rust-lang:masterfrom
tgross35:try-exists-wording
Apr 26, 2023
Merged

Update documentation wording on path 'try_exists' functions#110266
bors merged 1 commit into
rust-lang:masterfrom
tgross35:try-exists-wording

Conversation

@tgross35

@tgross35tgross35 commented Apr 13, 2023

Copy link
Copy Markdown
Member

Just eliminate the quadruple negation in doesn't silently ignore errors unrelated to ... not existing.

@rustbot

rustbot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 13, 2023
@rustbot

rustbot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

kadiwa4
kadiwa4 reviewed Apr 13, 2023
View reviewed changes
Comment threadlibrary/std/src/fs.rs Outdated
KittyBorgX
KittyBorgX approved these changes Apr 14, 2023
View reviewed changes
Comment threadlibrary/std/src/path.rs Outdated
Comment threadlibrary/std/src/path.rs Outdated
@jyn514

jyn514 commented Apr 26, 2023

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 9c567fd has been approved by jyn514

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
@jyn514jyn514 mentioned this pull request Apr 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2023
@bors
Auto merge ofrust-lang#110839- jyn514:rollup-uikilwm, r=jyn514
ae3ab14
Rollup of 9 pull requests
Successful merges:
- rust-lang#108416 (black_box doc corrections for clarification - Issue rust-lang#107957)
- rust-lang#109379 (Replace `yes` command by `while-echo` in test `tests/ui/process/process-sigpipe.rs`)
- rust-lang#110266 (Update documentation wording on path 'try_exists' functions)
- rust-lang#110329 (Improve tests for rust-lang#110138)
- rust-lang#110418 (Spelling rustdoc)
- rust-lang#110587 (Fix `std` compilation error for wasi+atomics)
- rust-lang#110594 (`rustc --help` add `--cfg` SPEC declaration.)
- rust-lang#110792 (Use the standard macOS CI runner)
- rust-lang#110817 (Add regression tests for const-generic inherent associated types)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ce30232 into rust-lang:masterApr 26, 2023
@rustbotrustbot added this to the 1.71.0 milestone Apr 26, 2023
@tgross35
tgross35 deleted the try-exists-wording branch April 26, 2023 20:47
@tgross35tgross35 mentioned this pull request Apr 26, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@kadiwa4kadiwa4kadiwa4 left review comments
@KittyBorgXKittyBorgXKittyBorgX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@thomccthomcc

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

7 participants

@tgross35@rustbot@jyn514@bors@kadiwa4@KittyBorgX@thomcc