Uh oh!
There was an error while loading. Please reload this page.
stdarch: update submodule - #110285
Conversation
rustbot
commented
Apr 13, 2023
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
commented
Apr 13, 2023
|
rustbot
commented
Apr 13, 2023
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
JohnTitor
commented
Apr 14, 2023
r? @Amanieu |
Amanieu
commented
Apr 15, 2023
@bors r+ |
bors
commented
Apr 15, 2023
bors
commented
Apr 15, 2023
⌛ Testing commit d5357c1 with merge 727db2d74e04267f48bbe758ac55ac05168bf4c3... |
bors
commented
Apr 15, 2023
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
KisaragiEffective
commented
Apr 16, 2023
@bors retry |
bors
commented
Apr 16, 2023
@KisaragiEffective: 🔑 Insufficient privileges: not in try users |
Amanieu
commented
Apr 21, 2023
cc @lu-zero I think this failure may be due to your powerpc changes. |
Amanieu
commented
Apr 23, 2023
This should be fixed by rust-lang/stdarch#1420. |
lu-zero
commented
Apr 23, 2023
Somehow the notification did not hit my mailbox properly, sorry for the noise. |
Amanieu
commented
Apr 23, 2023
@bors r+ |
bors
commented
Apr 23, 2023
bors
commented
Apr 24, 2023
bors
commented
Apr 25, 2023
⌛ Testing commit 1042b65 with merge faca88b6c23897bb1e9053125de3518858ed3837... |
This comment has been minimized.
This comment has been minimized.
bors
commented
Apr 25, 2023
💔 Test failed - checks-actions |
The above test failure is related to rust-lang/stdarch#1407. Removing the following line should fix it. rust/library/std/tests/run-time-detect.rs Line 19 in f6830a2 |
Amanieu
commented
May 6, 2023
You need to apply the change in #110285 (comment) to your PR otherwise the tests will not pass. |
KisaragiEffective
commented
May 8, 2023
It should be updated properly. |
Amanieu
commented
May 8, 2023
No, you need to delete this line on the rust-lang/rust side: https://github.com/rust-lang/rust/blob/master/library/std/tests/run-time-detect.rs#L19 |
KisaragiEffective
commented
May 8, 2023
Oh, okay... |
please see rust-lang#110285 (comment) for more details
Amanieu
commented
May 8, 2023
@bors r+ |
bors
commented
May 8, 2023
bors
commented
May 9, 2023
bors
commented
May 9, 2023
☀️ Test successful - checks-actions |
rust-timer
commented
May 9, 2023
Finished benchmarking commit (f7b831a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 659.045s -> 658.646s (-0.06%) |
please see rust-lang/rust#110285 (comment) for more details
We need this commit introduced by stdarch#1411 in order to merge #110189.
Note to myself:
git pull && git submodule update --remote library/stdarch