Uh oh!
There was an error while loading. Please reload this page.
rustdoc: stop passing a title to replaceState second argument - #110341
Merged
Conversation
rustbot
commented
Apr 14, 2023
Collaborator
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
commented
Apr 14, 2023
Collaborator
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
notriddleforce-pushed
the
notriddle/main-js-replacestate
branch
from
April 14, 2023 23:12
4aa72ee to
3ed9b55CompareGuillaumeGomez
approved these changes
Apr 15, 2023
Uh oh!
There was an error while loading. Please reload this page.
As described on [MDN's replaceState page], this parameter is not currently used, and the empty string is "safe against future changes to the method." [MDN's replaceState page]: https://developer.mozilla.org/en-US/docs/Web/API/History/replaceState
notriddleforce-pushed
the
notriddle/main-js-replacestate
branch
from
April 15, 2023 20:15
3ed9b55 to
0c61f58Comparenotriddle
commented
Apr 15, 2023
ContributorAuthor
GuillaumeGomez
approved these changes
Apr 16, 2023
GuillaumeGomez
commented
Apr 16, 2023
Member
Thanks! @bors r+ rollup |
bors
commented
Apr 16, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#110038 (Erase regions when confirming transmutability candidate) - rust-lang#110341 (rustdoc: stop passing a title to `replaceState` second argument) - rust-lang#110388 (Add a message for if an overflow occurs in `core::intrinsics::is_nonoverlapping`.) - rust-lang#110404 (fix clippy::toplevel_ref_arg and ::manual_map) - rust-lang#110421 (Spelling librustdoc) - rust-lang#110423 (Spelling srcdoc) - rust-lang#110433 (Windows: map a few more error codes to ErrorKind) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described on MDN's replaceState page, this parameter is not currently used, and the empty string is "safe against future changes to the method."