Uh oh!
There was an error while loading. Please reload this page.
Rollup of 4 pull requests - #110405
Merged
Merged
Conversation
This allows us to get rid of the `rustc_const_eval->rustc_borrowck` dependency edge which was delaying the compilation of borrowck. The added utils in `rustc_middle` are small and should not affect compile times there.
…lt, option_map_or_none}
Perf is almost certainly irrelevant, but might as well simplify it, since `trailing_zeros` does exactly what's needed.
…e1-dead,jyn514 Move some utils out of `rustc_const_eval` This allows us to get rid of the `rustc_const_eval->rustc_borrowck` dependency edge which was delaying the compilation of borrowck. The added utils in `rustc_middle` are small and should not affect compile times there.
…rieb,fee1-dead use matches! macro in more places r? `@Nilstrieb`
more clippy fixes: clippy::{iter_cloned_collect, unwarp_or_else_defau…
…lt, option_map_or_none}
r? `@Nilstrieb`Remove the loop in `Align::from_bytes` Perf is almost certainly irrelevant, but might as well simplify it, since `trailing_zeros` does exactly what's needed.
fee1-dead
commented
Apr 16, 2023
MemberAuthor
@bors r+ rollup=never p=4 |
bors
commented
Apr 16, 2023
Collaborator
fee1-dead
commented
Apr 16, 2023
MemberAuthor
@bors r- |
fee1-dead
commented
Apr 16, 2023
MemberAuthor
@bors r+ |
bors
commented
Apr 16, 2023
Collaborator
bors
commented
Apr 16, 2023
Collaborator
bors
commented
Apr 16, 2023
Collaborator
☀️ Test successful - checks-actions |
1 similar comment
bors
commented
Apr 16, 2023
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Apr 16, 2023
Collaborator
📌 Perf builds for each rolled up PR:
previous master: 8a778ca1e3 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Apr 16, 2023
Collaborator
📌 Perf builds for each rolled up PR: previous master: 1b50ea9abb In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Apr 16, 2023
Collaborator
Finished benchmarking commit (8a778ca): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_const_eval#110397 (Move some utils out ofrustc_const_eval)Align::from_bytes#110402 (Remove the loop inAlign::from_bytes)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup