Skip to content

Spelling rustc codegen gcc - #110415

Closed
jsoref wants to merge 4 commits into
rust-lang:masterfrom
jsoref:spelling-rustc_codegen_gcc
Closed

Spelling rustc codegen gcc#110415
jsoref wants to merge 4 commits into
rust-lang:masterfrom
jsoref:spelling-rustc_codegen_gcc

Conversation

@jsoref

Copy link
Copy Markdown
Contributor

this is a subset of #110392

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@rustbot

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 16, 2023
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@jsoref

Copy link
Copy Markdown
ContributorAuthor

oops, sorry, i'll push this to some other repo

@jsorefjsoref closed this Apr 16, 2023
@jsoref

Copy link
Copy Markdown
ContributorAuthor

Notably, there was some disclaimer about sending changes to rust if they crossed boundaries. the compiler/rustc_codegen_cranelift/example/std_example.rs file appears to have the same content as compiler/rustc_codegen_gcc/example/std_example.rs, i'm not sure if it matters if it gets out of sync. For the time being, I'm going to assume it doesn't matter and split the baby.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jsoref@rustbot@lcnr