Skip to content

Spelling src ci - #110430

Merged
bors merged 1 commit into
rust-lang:masterfrom
jsoref:spelling-src-ci
Apr 19, 2023
Merged

Spelling src ci#110430
bors merged 1 commit into
rust-lang:masterfrom
jsoref:spelling-src-ci

Conversation

@jsoref

Copy link
Copy Markdown
Contributor

The various src/* items seem slightly disparate, so I'm doing src/* individually.

split from #110392

@rustbot

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pietroalbini (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 16, 2023
Comment threadsrc/ci/docker/README.md Outdated

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notable

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notable

@albertlarsan68

Copy link
Copy Markdown
Member

LGTM
@bors rollup
r=me once squashed

* architecture
* configures
* preparation
* toolstate
* unknown
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@albertlarsan68albertlarsan68 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2023
@jsoref

Copy link
Copy Markdown
ContributorAuthor

@albertlarsan68: are you waiting for something from me?

@albertlarsan68

Copy link
Copy Markdown
Member

Thanks for the PR!
@bors r+ rollup

@bors

bors commented Apr 19, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 9c8d10a has been approved by albertlarsan68

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2023
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#110123 ('./configure' now checks if 'config.toml' exists before writing to that destination)
- rust-lang#110429 (Spelling src bootstrap)
- rust-lang#110430 (Spelling src ci)
- rust-lang#110515 (Don't special-case download-rustc in `maybe_install_llvm`)
- rust-lang#110521 (Fix `x test lint-docs linkchecker` when download-rustc is enabled)
- rust-lang#110525 (Fix `tests/run-make-translation` when download-rustc is enabled)
- rust-lang#110531 (small type system cleanup)
- rust-lang#110533 (Missing blanket impl trait not public)
- rust-lang#110540 (Fix wrong comment in rustc_hir/src/hir.rs)
- rust-lang#110541 (Fix various configure bugs)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit dc0de09 into rust-lang:masterApr 19, 2023
@rustbotrustbot added this to the 1.71.0 milestone Apr 19, 2023
@jsoref
jsoref deleted the spelling-src-ci branch April 19, 2023 21:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jsoref@rustbot@albertlarsan68@bors@emilyalbini