Uh oh!
There was an error while loading. Please reload this page.
Spelling src etc - #110431
Conversation
rustbot
commented
Apr 16, 2023
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
jsoref
left a comment
There was a problem hiding this comment.
I'll squash if the changes are ok
There was a problem hiding this comment.
This is the only interesting part of this change. I'm assuming that uppercase doesn't imply a frozen/public symbol.
Mark-Simulacrum
commented
Apr 19, 2023
Please squash commits, r=me after that. |
spelling: exactly spelling: synthetic Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
commented
Apr 20, 2023
@Mark-Simulacrum squashed |
Mark-Simulacrum
commented
Apr 20, 2023
@bors r+ |
bors
commented
Apr 20, 2023
bors
commented
Apr 21, 2023
bors
commented
Apr 21, 2023
☀️ Test successful - checks-actions |
1 similar comment
bors
commented
Apr 21, 2023
☀️ Test successful - checks-actions |
rust-timer
commented
Apr 21, 2023
Finished benchmarking commit (77778e0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
The various src/* items seem slightly disparate, so I'm doing src/* individually.
split from #110392