Skip to content

cmp doc examples improvements - #110448

Merged
bors merged 1 commit into
rust-lang:masterfrom
ripytide:master
Apr 20, 2023
Merged

cmp doc examples improvements#110448
bors merged 1 commit into
rust-lang:masterfrom
ripytide:master

Conversation

@ripytide

@ripytideripytide commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

Most changes are for stylistic consistency, with some changes to provide more clarity.

@rustbot

rustbot commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2023
@rustbot

rustbot commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@cuviper

cuviper commented Apr 20, 2023

Copy link
Copy Markdown
Member

Thanks, it does look nicer to me!

@bors r+ rollup

@bors

bors commented Apr 20, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit f540548 has been approved by cuviper

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2023
@JohnTitorJohnTitor mentioned this pull request Apr 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2023
@bors
Auto merge ofrust-lang#110585- JohnTitor:rollup-gfffoiv, r=JohnTitor
13fc33e
Rollup of 7 pull requests
Successful merges:
- rust-lang#102341 (Implement `Neg` for signed non-zero integers.)
- rust-lang#110424 (Spelling misc)
- rust-lang#110448 (cmp doc examples improvements)
- rust-lang#110516 (bootstrap: Update linux-raw-sys to 0.3.2)
- rust-lang#110548 (Make `impl Debug for Span` not panic on not having session globals.)
- rust-lang#110554 (`deny(unsafe_op_in_unsafe_fn)` in `rustc_data_structures`)
- rust-lang#110575 (fix lint regression in `non_upper_case_globals`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9dbd25c into rust-lang:masterApr 20, 2023
@rustbotrustbot added this to the 1.71.0 milestone Apr 20, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuvipercuviper

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ripytide@rustbot@cuviper@bors