Uh oh!
There was an error while loading. Please reload this page.
Tweak borrow suggestion span - #110504
Merged
Merged
Conversation
rustbot
commented
Apr 18, 2023
Collaborator
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
cjgillot
commented
Apr 18, 2023
Contributor
Could you completely remove the span_to_snippet call by making the suggestion multipart? |
compiler-errors
commented
Apr 18, 2023
ContributorAuthor
I could, but that would require a bit more work, since this function currently has a very strange API: I guess I'll look into it. |
cjgillot
commented
Apr 28, 2023
Contributor
@bors r+ |
bors
commented
Apr 28, 2023
Collaborator
bors
commented
Apr 28, 2023
Collaborator
🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened. |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 29, 2023
… r=cjgillot Tweak borrow suggestion span Avoids a `span_to_snippet` call when we don't need to surround the expression in parentheses. The fact that the suggestion was using the whole span of the expression rather than just appending a `&` was prevented me from using `// run-rustfix` in another PR (rust-lang#110432 (comment)). Also some drive-by renames of functions that have been annoying me for a bit.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 29, 2023
… r=cjgillot Tweak borrow suggestion span Avoids a `span_to_snippet` call when we don't need to surround the expression in parentheses. The fact that the suggestion was using the whole span of the expression rather than just appending a `&` was prevented me from using `// run-rustfix` in another PR (rust-lang#110432 (comment)). Also some drive-by renames of functions that have been annoying me for a bit.
matthiaskrgr
commented
Apr 29, 2023
Member
@bors r- needs rebase I guess |
rust-cloud-vmsBotforce-pushed
the
tweak-borrow-sugg
branch
from
May 1, 2023 16:10
cf24419 to
f0e7af4Comparecompiler-errors
commented
May 1, 2023
ContributorAuthor
rebased @bors r=cjgillot |
bors
commented
May 1, 2023
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 1, 2023
… r=cjgillot Tweak borrow suggestion span Avoids a `span_to_snippet` call when we don't need to surround the expression in parentheses. The fact that the suggestion was using the whole span of the expression rather than just appending a `&` was prevented me from using `// run-rustfix` in another PR (rust-lang#110432 (comment)). Also some drive-by renames of functions that have been annoying me for a bit.
bors
commented
May 3, 2023
Collaborator
☔ The latest upstream changes (presumably #110579) made this pull request unmergeable. Please resolve the merge conflicts. |
We really shouldn't be naming functions `fn check_*` unless they're doing *typechecking*. It's especially misleading when we're doing this inside of HIR typeck.
compiler-errorsforce-pushed
the
tweak-borrow-sugg
branch
from
May 8, 2023 03:42
f0e7af4 to
4731a25Comparecompiler-errors
commented
May 8, 2023
ContributorAuthor
rebased again @bors r=cjgillot |
bors
commented
May 8, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 9, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#110304 (Add GNU Property Note) - rust-lang#110504 (Tweak borrow suggestion span) - rust-lang#110583 (tweak "make mut" spans when assigning to locals) - rust-lang#110694 (Implement builtin # syntax and use it for offset_of!(...)) - rust-lang#111120 (Suggest let for possible binding with ty) - rust-lang#111252 (Min specialization improvements) - rust-lang#111361 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids a
span_to_snippetcall when we don't need to surround the expression in parentheses. The fact that the suggestion was using the whole span of the expression rather than just appending a&was prevented me from using// run-rustfixin another PR (#110432 (comment)).Also some drive-by renames of functions that have been annoying me for a bit.