Skip to content

Suggest deref on comparison binop RHS even if type is not Copy - #110550

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:deref-on-binop-rhs
Apr 26, 2023
Merged

Suggest deref on comparison binop RHS even if type is not Copy#110550
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:deref-on-binop-rhs

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Fixes#110500

@rustbot

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 19, 2023
@wesleywiser

Copy link
Copy Markdown
Member

Thanks @compiler-errors!

@bors r+ rollup

@bors

bors commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit b0a7d6e has been approved by wesleywiser

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2023
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#108760 (Add lint to deny diagnostics composed of static strings)
- rust-lang#109444 (Change tidy error message for TODOs)
- rust-lang#110419 (Spelling library)
- rust-lang#110550 (Suggest deref on comparison binop RHS even if type is not Copy)
- rust-lang#110641 (Add new rustdoc book chapter to describe in-doc settings)
- rust-lang#110798 (pass `unused_extern_crates` in `librustdoc::doctest::make_test`)
- rust-lang#110819 (simplify TrustedLen impls)
- rust-lang#110825 (diagnostics: add test case for already-solved issue)
- rust-lang#110835 (Make some region folders a little stricter.)
- rust-lang#110847 (rustdoc-json: Time serialization.)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 8e6fffc into rust-lang:masterApr 26, 2023
@rustbotrustbot added this to the 1.71.0 milestone Apr 26, 2023
@compiler-errors
compiler-errors deleted the deref-on-binop-rhs branch August 11, 2023 19:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't advise cloning when using relational operators

4 participants

@compiler-errors@rustbot@wesleywiser@bors