Uh oh!
There was an error while loading. Please reload this page.
Add Call terminator to SMIR - #110558
Merged
Merged
Conversation
rustbot
commented
Apr 19, 2023
Collaborator
oli-obk
reviewed
Apr 20, 2023
Comment on lines
161
to
164
Contributor
There was a problem hiding this comment.
We should probably copy the UnwindAction enum to smir instead of losing the information about which behaviour is desired here.
MemberAuthor
There was a problem hiding this comment.
Agreed, made the change but only applied to Call. We would need to apply to Assert, etc but we can do that as we go I guess.
spastorinoforce-pushed
the
smir-call-terminator
branch
from
April 20, 2023 15:07
1f14eda to
2f50334Compareoli-obk
commented
Apr 20, 2023
Contributor
@bors r+ rollup |
bors
commented
Apr 20, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 20, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#108795 (Add support for the x86_64h-apple-darwin target) - rust-lang#110558 (Add Call terminator to SMIR) - rust-lang#110565 (linkchecker: running from a directory separate from the book) - rust-lang#110599 (Remove an unused `&[Ty]` <-> `&[GenericArg]`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds internal MIR
TerminatorKind::Callto SMIRTerminator::Callconversion.r? @oli-obk