Uh oh!
There was an error while loading. Please reload this page.
Add impl_tag! macro to implement Tag for tagged pointer easily - #110615
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
rust-cloud-vmsBotforce-pushed
the
impl_tag
branch
from
April 20, 2023 16:54
a8dcee7 to
9ba03e4Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vmsBotforce-pushed
the
impl_tag
branch
from
April 20, 2023 17:14
9ba03e4 to
77c83c0CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Noratrieb
left a comment
Member
There was a problem hiding this comment.
Very cool. I didn't spot any issues except two nits, although I may want to take a second look when you've fixed those.
klensy
reviewed
Apr 20, 2023
Uh oh!
There was an error while loading. Please reload this page.
rust-cloud-vmsBotforce-pushed
the
impl_tag
branch
from
April 20, 2023 19:29
a5ac778 to
1c74c71Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vmsBotforce-pushed
the
impl_tag
branch
from
April 20, 2023 19:54
1c74c71 to
ad8c7b6Compare| ( | ||
| impl Tag for $Self:ty; | ||
| $( | ||
| $($path:ident)::* $( { $( $fields:tt )* })? <=> $tag:literal, |
Contributor
There was a problem hiding this comment.
Is customization according to $tag useful?
If not, you can use ${index()} to generate it automatically, like rustc_metadata::rmeta::table does.
MemberAuthor
There was a problem hiding this comment.
I guess the answer is "it could, but probably isn't". I'll work on it next week.
WaffleLapkin
commented
Apr 24, 2023
MemberAuthor
@rustbot ready |
cjgillot
commented
Apr 25, 2023
Contributor
Great! |
bors
commented
Apr 25, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110556 (Switch to `EarlyBinder` for `explicit_item_bounds`) - rust-lang#110615 (Add `impl_tag!` macro to implement `Tag` for tagged pointer easily) - rust-lang#110649 (Fix no_global_oom_handling build) - rust-lang#110671 (Consider polarity in new solver) - rust-lang#110783 (Fix ICE on --print=... i/o errors) - rust-lang#110796 (Updating Wake example to use new 'pin!' macro) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @Nilstrieb
This should also lifts the need to think about safety from the callers (
impl_tag!is robust (ish, see the macro issue)) and removes the possibility of making a "weird"Tagimpl.