Skip to content

Fix grammar in core::hint::unreachable_unchecked() docs - #110689

Merged
bors merged 1 commit into
rust-lang:masterfrom
Spartan2909:fix-grammar
Apr 24, 2023
Merged

Fix grammar in core::hint::unreachable_unchecked() docs#110689
bors merged 1 commit into
rust-lang:masterfrom
Spartan2909:fix-grammar

Conversation

@Spartan2909

@Spartan2909Spartan2909 commented Apr 22, 2023

Copy link
Copy Markdown
Contributor

Fixes a minor grammar error in the docs for core::hint::unreachable_unchecked()

@rustbot

rustbot commented Apr 22, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 22, 2023
@rustbot

rustbot commented Apr 22, 2023

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@JohnTitor

JohnTitor commented Apr 23, 2023

Copy link
Copy Markdown
Member

Thanks! @bors r+ rollup

@bors

bors commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 0cc1b86 has been approved by JohnTitor

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2023
@matthiaskrgrmatthiaskrgr mentioned this pull request Apr 23, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2023
@bors
Auto merge ofrust-lang#110736- matthiaskrgr:rollup-gorv8zp, r=matth…
8991768
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#110661 (rustdoc: clean up settings.css and settings.js)
- rust-lang#110663 (Add note about change in bootstrap defaults)
- rust-lang#110664 (stop `x fmt` formatting untracked directories)
- rust-lang#110668 (Fix printing native CPU on cross-compiled compiler.)
- rust-lang#110689 (Fix grammar in core::hint::unreachable_unchecked() docs)
- rust-lang#110700 (Don't infer fn return type to return itself)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 96acbd8 into rust-lang:masterApr 24, 2023
@rustbotrustbot added this to the 1.71.0 milestone Apr 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@thomccthomcc

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Spartan2909@rustbot@JohnTitor@bors@thomcc