Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #110704
Closed
compiler-errors wants to merge 20 commits into
Closed
Conversation
- Use `cargo metadata` to determine whether a crate has a library package or not - Collect metadata for all workspaces, not just the root workspace and cargo - Don't pass `--lib` for crates without a library - Use `run_cargo_test` for rust-installer - Don't build documentation in `lint-docs` if `--no-doc` is passed
This code was added in 9dc5dfb and 704050d because the browser- native checkbox was `display: none`, breaking native keyboard accessibility. The native checkbox is now merely `appearance: none`, which does not turn off [behavior semantics], so JavaScript to reimplement it isn't needed any more. [behavior semantics]: https://w3c.github.io/csswg-drafts/css-ui/#appearance-semantics
This code was added back when `border-color: currentColor` was used. Since it was changed in ad9a89e, the current color is not used any more.
Refactor `SyntaxContext::ctxt` logic. I'm still trying to make a test from the issue. cc ```@deepink-mas``` does this solve the issue? Fixesrust-lang#110230
…levant_impl, r=b-naber Remove `find_map_relevant_impl` Fixesrust-lang#108895
bootstrap: Unify test argument handling Fixesrust-lang#104198. Does *not* help with rust-lang#80124 because I couldn't figure out a reasonable way to omit `--lib` only for `panic_abort` and not other `std` dependencies. - Remove unnecessary `test_kind` field and `TestKind` struct. These are just subsets of the existing `builder.kind` / `Kind` struct. - Add a new `run_cargo_test` function which handles passing arguments to cargo based on `builder.config` - Switch all Steps in `mod test` to `run_cargo_test` where possible - Combine several steps into one `CrateBootstrap` step. These tests all do the same thing, just with different crate names. - Fix `x test --no-doc`. This is much simpler after the refactors mentioned earlier, but I'm happy to split it into a separate PR if desired. Before, this would panic a lot because steps forgot to pass `--lib`.
…ndlekey, r=GuillaumeGomez rustdoc: clean up settings.css and settings.js `handleKey` was added in 9dc5dfb and 704050d because the browser-native checkbox was `display: none`, breaking native keyboard accessibility. The native checkbox is now merely `appearance: none`, which does not turn off [behavior semantics], so JavaScript to reimplement it isn't needed any more. [behavior semantics]: https://w3c.github.io/csswg-drafts/css-ui/#appearance-semantics The other, one line change to settings.css is follow-up to rust-lang#110205
…=cuviper Add note about change in bootstrap defaults Not a huge fan of the proposed wording, open to changes in that. Per rust-lang#106886 (comment). cc `@jonhoo` r? `@cuviper` perhaps?
…t, r=jyn514 stop `x fmt` formatting untracked directories I don't think there's anything else to do? I've confirmed that you get a "skip untracked path foo/ during rustfmt invocations" for the alternative build directory. r? ```@jyn514```
Don't infer fn return type to return itself Fixesrust-lang#110687
compiler-errors
commented
Apr 22, 2023
ContributorAuthor
@bors r+ rollup=never p=7 |
bors
commented
Apr 22, 2023
Collaborator
bors
commented
Apr 23, 2023
Collaborator
⌛ Testing commit eb33b1d with merge 56ce5a3c0390a6716a8dbcd3c887f55988778ea1... |
bors
commented
Apr 23, 2023
Collaborator
💥 Test timed out |
rust-log-analyzer
commented
Apr 23, 2023
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
SyntaxContext::ctxtlogic. #110497 (RefactorSyntaxContext::ctxtlogic.)find_map_relevant_impl#110514 (Removefind_map_relevant_impl)x fmtformatting untracked directories #110664 (stopx fmtformatting untracked directories)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup