Skip to content

Limit lifetime of format_args!() with inlined args. - #110770

Merged
bors merged 1 commit into
rust-lang:masterfrom
m-ou-se:fmt-temp-lifetime
May 9, 2023
Merged

Limit lifetime of format_args!() with inlined args.#110770
bors merged 1 commit into
rust-lang:masterfrom
m-ou-se:fmt-temp-lifetime

Conversation

@m-ou-se

@m-ou-sem-ou-se commented Apr 24, 2023

Copy link
Copy Markdown
Member

Fixes#110769

@m-ou-sem-ou-se added the A-fmt Area: `core::fmt` label Apr 24, 2023
@rustbot

Copy link
Copy Markdown
Collaborator

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 24, 2023
@m-ou-se
m-ou-seforce-pushed the fmt-temp-lifetime branch from 7aca10c to d5843ddCompareMay 9, 2023 14:08
@m-ou-se
m-ou-se marked this pull request as ready for review May 9, 2023 14:11
@rustbot

This comment was marked as resolved.

@m-ou-se

Copy link
Copy Markdown
MemberAuthor

r? @oli-obk

@oli-obk

Copy link
Copy Markdown
Contributor

r=me with a regression test added

@m-ou-se

m-ou-se commented May 9, 2023

Copy link
Copy Markdown
MemberAuthor

@oli-obk

Copy link
Copy Markdown
Contributor

That you did, I just didn't realize it was more than good documentation

@bors r+ rollup

@bors

bors commented May 9, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit d5843dd has been approved by oli-obk

It is now in the queue for this repository.

@bors

bors commented May 9, 2023

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 9, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2023
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#97320 (Stabilize const_ptr_read)
- rust-lang#110770 (Limit lifetime of format_args!() with inlined args.)
- rust-lang#111021 (Move some tests)
- rust-lang#111215 (Various changes to name resolution of anon consts)
- rust-lang#111242 (support set `rpath` option for each target independently)
- rust-lang#111282 (Remove some `assume`s from slice iterators that don't do anything)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit e4c8250 into rust-lang:masterMay 9, 2023
@rustbotrustbot added this to the 1.71.0 milestone May 9, 2023
@m-ou-se
m-ou-se deleted the fmt-temp-lifetime branch May 10, 2023 10:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-fmtArea: `core::fmt`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

format_args!() inlining/flattening allows for longer lifetimes

5 participants

@m-ou-se@rustbot@oli-obk@bors@scottmcm