Rollup of 10 pull requests by JohnTitor · Pull Request #110778 · rust-lang/rust

JohnTitor · 2023-04-24T17:33:32Z

Successful merges:

Add known-bug tests for 11 unsound issues #110480 (Add known-bug tests for 11 unsound issues)
Move around {Idx, IndexVec, IndexSlice} adjacent code #110539 (Move around {Idx, IndexVec, IndexSlice} adjacent code)
Add some tests around (lack of) object safety of associated types and consts #110590 (Add some tests around (lack of) object safety of associated types and consts)
Ignore src/bootstrap formatting commit in .git-blame-ignore-revs #110602 (Ignore src/bootstrap formatting commit in .git-blame-ignore-revs)
pointer-auth-link-with-c: Fix cross compilation. #110667 (pointer-auth-link-with-c: Fix cross compilation.)
drop few unused crates, gate libc under unix for rustc_codegen_ssa #110681 (drop few unused crates, gate libc under unix for rustc_codegen_ssa)
Some cleanups to DataflowConstProp #110685 (Some cleanups to DataflowConstProp)
bootstrap: update paths cargo-credential crate #110744 (bootstrap: update paths cargo-credential crate)
Add size asserts for MIR SourceScopeData & VarDebugInfo #110750 (Add size asserts for MIR SourceScopeData & VarDebugInfo)
rustdoc: Add regression test for #60522 #110760 (rustdoc: Add regression test for Glob-duplicated item names produce duplicated entries in rustdoc #60522)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

… consts

This should be done in rust-lang#110653 but forgot.

There's vectors of both of these in `mir::Body`, so might as well track them.

…unsound-issues, r=jackh726 Add `known-bug` tests for 11 unsound issues r? ``@jackh726`` Should tests for other issues be in separate PRs? Thanks. Edit: Partially addresses rust-lang#105107. This PR adds `known-bug` tests for 11 unsound issues: - rust-lang#25860 - rust-lang#49206 - rust-lang#57893 - rust-lang#84366 - rust-lang#84533 - rust-lang#84591 - rust-lang#85099 - rust-lang#98117 - rust-lang#100041 - rust-lang#100051 - rust-lang#104005

…, r=cjgillot Move around `{Idx, IndexVec, IndexSlice}` adjacent code r? ``@scottmcm``

…=jackh726 Add some tests around (lack of) object safety of associated types and consts See https://rust-lang.zulipchat.com/#narrow/stream/144729-t-types/topic/.60where.20Self.3ASized.60.20on.20assoc.20types/near/351260928 for some discussion around why this isn't allowed. We didn't have any tests for these, so I decided to add them now, even if we don't end up doing anything about it.

Ignore src/bootstrap formatting commit in .git-blame-ignore-revs rust-lang@b39a1d6

…r=Mark-Simulacrum pointer-auth-link-with-c: Fix cross compilation.

drop few unused crates, gate libc under unix for rustc_codegen_ssa Small cleanup.

Some cleanups to DataflowConstProp Mostly moving code around and short-circuiting useless cases.

…, r=ehuss bootstrap: update paths cargo-credential crate This should be done in rust-lang#110653 but forgot. Fixesrust-lang#110742 ## How to verify this patch Run `./x.py build cargo`. Previously it would fail with ```console error: manifest path `/projects/rust/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist ```

Add size asserts for MIR `SourceScopeData` & `VarDebugInfo` There's vectors of both of these in `mir::Body`, so might as well track them. (I was pondering adding something to one or the other, so wanted this to see the memory impact.)

…=notriddle rustdoc: Add regression test for rust-lang#60522Fixesrust-lang#60522. r? `@notriddle`

JohnTitor · 2023-04-24T17:33:52Z

@bors r+ p=10 rollup=never

bors · 2023-04-24T17:33:54Z

📌 Commit 513c0cc has been approved by JohnTitor

It is now in the queue for this repository.

bors · 2023-04-24T19:09:24Z

⌛ Testing commit 513c0cc with merge 521de43...

bors · 2023-04-24T21:25:47Z

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing 521de43 to master...

rust-timer · 2023-04-24T21:28:37Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#110760	2e33037536f0e69392b103c58be93eb8d1dbb9ac
#110750	ae75c5501531da86a8641f86926d28edef52f38a
#110744	345f4ea6757a287be7d89f1fb7b05b4312fa3938
#110685	ab5238eece19414a6bcf10991d4c4fd1d73275d0
#110681	d00d9dcdae91a61943d01dca784b097f6af833e3
#110667	521591be2e719633be202eabe25552f94a793320
#110602	ca6cc1741193acca948d53624610eeda0dfb7b42
#110590	1a308c2522037261d1392507699fe7af7999eb9c
#110539	b8b3c209207b164eb9c2c4142cd7e866c3452c41
#110480	7e1a8778e622f9e92d24a90d741f3ed9221da14b

previous master: 253b727f46

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-04-24T22:59:14Z

Finished benchmarking commit (521de43): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.3%	[4.3%, 4.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.3%	[4.3%, 4.3%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.8%, -2.9%]	2
All ❌✅ (primary)	-	-	0

oli-obkand others added 30 commits April 20, 2023 09:41

Add some tests around (lack of) object safety of associated types and…
41e3cc4
… consts

Ignore src/bootstrap formatting commit in .git-blame-ignore-revs
704a9da

pointer-auth-link-with-c: Fix cross compilation.
fa35156

add known-bug test for unsound issue 25860
adb5ded

add known-bug test for unsound issue 49206
2fb2098

add known-bug test for unsound issue 57893
232d685

add known-bug test for unsound issue 84366
fbfb620

add known-bug test for unsound issue 84533
cac62ab

add known-bug test for unsound issue 84591
be68c69

add known-bug test for unsound issue 85099
3c5de9a

drop unused deps, gate libc under unix for one crate
3338ee3

Remove useless special case.
0e68cbd

Move eval_discriminant.
629cdb4

Simplify logic.
dd452ae

Reduce rightward drift.
dd78b99

add known-bug test for unsound issue 98117
3141262

add known-bug test for unsound issue 100041
cff6c0e

add known-bug test for unsound issue 100051
6f6550f

add known-bug test for unsound issue 104005
ebe61ce

bootstrap: update paths cargo-credential crate
f5e535c
This should be done in rust-lang#110653 but forgot.

Add size asserts for MIR SourceScopeData & VarDebugInfo
31531ce
There's vectors of both of these in `mir::Body`, so might as well track them.

Add regression test forrust-lang#60522
5c70287

Split {Idx, IndexVec, IndexSlice} into their own modules
e496fbe

move index code around
99ebfe2

const-ify some {IndexVec, IndexSlice} methods
7d23b52

Decorative changes to IndexVec
5d809b1

Fix rustc_index imports outside the compiler
c0daff0

Rollup merge ofrust-lang#110539- WaffleLapkin:split_index_vec&slice…
cefb479
…, r=cjgillot Move around `{Idx, IndexVec, IndexSlice}` adjacent code r? ``@scottmcm``

JohnTitor added 7 commits April 25, 2023 02:33

Rollup merge ofrust-lang#110602- jyn514:ignore-fmt, r=Mark-Simulacrum
e0bb7bb
Ignore src/bootstrap formatting commit in .git-blame-ignore-revs rust-lang@b39a1d6

Rollup merge ofrust-lang#110667- pcc:fix-pointer-auth-link-with-c, …
2a2df56
…r=Mark-Simulacrum pointer-auth-link-with-c: Fix cross compilation.

Rollup merge ofrust-lang#110681- klensy:cut-dep, r=lcnr
a373623
drop few unused crates, gate libc under unix for rustc_codegen_ssa Small cleanup.

Rollup merge ofrust-lang#110685- cjgillot:clean-dcp, r=oli-obk
4d3ab3d
Some cleanups to DataflowConstProp Mostly moving code around and short-circuiting useless cases.

Rollup merge ofrust-lang#110760- GuillaumeGomez:regression-60522, r…
513c0cc
…=notriddle rustdoc: Add regression test for rust-lang#60522Fixesrust-lang#60522. r? `@notriddle`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 24, 2023

bors merged commit 521de43 into rust-lang:masterApr 24, 2023

rustbot added this to the 1.71.0 milestone Apr 24, 2023

This was referenced Apr 24, 2023
Remove QueryEngine trait #109611
Merged
Fix target_feature 1.1 should print the list of missing target features #109710
Closed
Reimplement ConstProp using DataflowConstProp #110719
Closed

JohnTitor deleted the rollup-7f51qwk branch April 25, 2023 15:44

Navigation Menu

Uh oh!

Uh oh!

Rollup of 10 pull requests - #110778

Rollup of 10 pull requests#110778
bors merged 37 commits into
rust-lang:masterfrom
JohnTitor:rollup-7f51qwk

JohnTitor commented Apr 24, 2023

Uh oh!

JohnTitor commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

rust-timer commented Apr 24, 2023

Uh oh!

rust-timer commented Apr 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Uh oh!

Conversation

JohnTitor commented Apr 24, 2023

Uh oh!

JohnTitor commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

rust-timer commented Apr 24, 2023

Uh oh!

rust-timer commented Apr 24, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants