Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Fix missing repr attribute in doc(inline) on foreign items - #110901
Conversation
Noratrieb
commented
Apr 27, 2023
This encodes more attributes that may be quite common in some crates (like |
This comment has been minimized.
This comment has been minimized.
bors
commented
Apr 27, 2023
⌛ Trying commit 3f08284 with merge df3a8d02aba793baba13db9147d6d76767cd0f0c... |
notriddle
commented
Apr 27, 2023
If the overhead is considered unacceptable, I'm pretty sure rustdoc can reconstitute the data using |
bors
commented
Apr 27, 2023
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Apr 27, 2023
Finished benchmarking commit (df3a8d02aba793baba13db9147d6d76767cd0f0c): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
GuillaumeGomez
commented
Apr 27, 2023
Seems like the impact is small. \o/ |
notriddle
commented
Apr 27, 2023
@bors r+ |
bors
commented
Apr 27, 2023
GuillaumeGomez
commented
Apr 28, 2023
@bors rollup=iffy |
…c, r=notriddle rustdoc: Fix missing `repr` attribute in doc(inline) on foreign items Fixesrust-lang#110698. r? `@notriddle`
bors
commented
Apr 28, 2023
⌛ Testing commit 3f08284 with merge 98578d8df50afc667038c6094532d00b4da58691... |
bors
commented
Apr 28, 2023
💔 Test failed - checks-actions |
rust-log-analyzer
commented
Apr 28, 2023
ehuss
commented
Apr 28, 2023
@bors retry python setuptools issue |
bors
commented
Apr 28, 2023
bors
commented
Apr 28, 2023
☀️ Test successful - checks-actions |
rust-timer
commented
Apr 29, 2023
Finished benchmarking commit (f495605): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Fixes#110698.
r? @notriddle