Skip to content

Update awscli - #110952

Merged
bors merged 1 commit into
rust-lang:masterfrom
ehuss:update-awscli
Apr 28, 2023
Merged

Update awscli#110952
bors merged 1 commit into
rust-lang:masterfrom
ehuss:update-awscli

Conversation

@ehuss

Copy link
Copy Markdown
Contributor

The Windows GitHub Actions image just updated to pip 23.1.1 which broke the PyYaml installer in the current AWS CLI mirror. It now requires setuptools, wheel, and Cython to be installed manually. This updates to include that, as well as updating the versions of all the packages. This also now uses python3 on macOS since python2 doesn't work with the newer versions.

I have only tested that these install correctly, but not that they work correctly.

Pietro mentioned that we should just switch to aws cli 2, which I agree is probably the better solution. I'm posting this PR in case it helps unblock CI.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @pietroalbini

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 28, 2023
@cuviper

Copy link
Copy Markdown
Member

@bors r+ p=50

@bors

bors commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit dd6314f has been approved by cuviper

It is now in the queue for this repository.

@bors

bors commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2023
@bors

bors commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit dd6314f with merge f357475...

@bors

bors commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing f357475 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 28, 2023
@bors
bors merged commit f357475 into rust-lang:masterApr 28, 2023
@rustbotrustbot added this to the 1.71.0 milestone Apr 28, 2023
@cuvipercuviper mentioned this pull request Apr 28, 2023
@cuviper

Copy link
Copy Markdown
Member

I'm going ahead and pulling this into beta too, #110871.

@rustbot label +beta-accepted

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 28, 2023
@cuvipercuviper modified the milestones: 1.71.0, 1.70.0Apr 28, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f357475): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.3%[-0.3%, -0.3%]2
All ❌✅ (primary)--0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
3.3%[3.3%, 3.3%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)3.3%[3.3%, 3.3%]1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.1%[-2.1%, -2.1%]1
All ❌✅ (primary)--0

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2023
[beta] backport
This PR backports:
- Encode def span for ConstParam rust-lang#110425
- Update to LLVM 16.0.2 rust-lang#110535
- Encode lifetime param spans too rust-lang#110469
- make sysroot finding compatible with multiarch systems rust-lang#110281
- Update awscli rust-lang#110952
- Temporarily disable the jobserver-error test rust-lang#110361
Also bumps us to the latest released stable, 1.69.0.
r? `@cuviper`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcbeta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ehuss@rustbot@cuviper@bors@rust-timer@emilyalbini