Skip to content

Make drop_flags an IndexVec. - #110962

Merged
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:no-hash-drops
Apr 29, 2023
Merged

Make drop_flags an IndexVec.#110962
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:no-hash-drops

Conversation

@cjgillot

Copy link
Copy Markdown
Contributor

Fixes#91943

@rustbot

Copy link
Copy Markdown
Collaborator

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 28, 2023
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@compiler-errorscompiler-errors left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with ci green


bb0: {
+ _9 = const false; // scope 0 at $DIR/issue_41888.rs:+1:9: +1:10
+ _7 = const false; // scope 0 at $DIR/issue_41888.rs:+1:9: +1:10

@compiler-errorscompiler-errorsApr 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😄 this is good proof the order is more stable now, hehe

@compiler-errors

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 7f26191 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 29, 2023
@Dylan-DPCDylan-DPC mentioned this pull request Apr 29, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2023
Rollup of 6 pull requests
Successful merges:
- rust-lang#110614 (Clear response values for overflow in new solver)
- rust-lang#110894 (Bump libffi-sys to 2.3.0)
- rust-lang#110932 (include source error for LoadLibraryExW)
- rust-lang#110958 (Make sure that some stdlib method signatures aren't accidental refinements)
- rust-lang#110962 (Make drop_flags an IndexVec.)
- rust-lang#110965 (Don't duplicate anonymous lifetimes for async fn in traits)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7721c73 into rust-lang:masterApr 29, 2023
@rustbotrustbot added this to the 1.71.0 milestone Apr 29, 2023
@cjgillot
cjgillot deleted the no-hash-drops branch April 29, 2023 10:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop flag statement creation depends on FxHashMap interation order

5 participants

@cjgillot@rustbot@compiler-errors@bors@b-naber