Uh oh!
There was an error while loading. Please reload this page.
Dummy PR to check instrument-coverage test failures in CI - #111116
Dummy PR to check instrument-coverage test failures in CI#111116Zalathar wants to merge 2 commits into
Conversation
rustbot
commented
May 3, 2023
(rustbot has picked a reviewer for you, use r? to override) |
3dbe4b1 to
197dd01Comparerustbot
commented
May 3, 2023
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
Zalathar
commented
May 3, 2023
OK, this confirms that Now I'll try backing out the synthetic failure in |
OK, that test run succeeded, despite containing a Successful job link: https://github.com/rust-lang/rust/actions/runs/4868140937/jobs/8681353114 Now I'll try specifically modifying that file. |
KittyBorgX
commented
May 3, 2023
r? @ghost |
rustbot
commented
May 3, 2023
Failed to set assignee to
|
Dylan-DPC
commented
May 3, 2023
r? @ghost |
rustbot
commented
May 3, 2023
Failed to set assignee to
|
Zalathar
commented
May 3, 2023
My most recent change deliberately added another error to The corresponding test run inappropriately succeeded: https://github.com/rust-lang/rust/actions/runs/4868472221/jobs/8681992254 |
Zalathar
commented
May 3, 2023
Now I'll try bumping |
Even modifying Successful job link: https://github.com/rust-lang/rust/actions/runs/4868994006/jobs/8683000830 Next I'm going to take the extreme measure of replacing |
This comment has been minimized.
This comment has been minimized.
Zalathar
commented
May 3, 2023
Based on this evidence, I think the |
Zalathar
commented
May 3, 2023
Based on my new hypothesis, I've modified Hopefully this should eliminate any subtle differences between GNU |
This comment has been minimized.
This comment has been minimized.
It seems clear that the person responsible for this headache is ... me, via #110942. There seems to be some subtle difference in how GNU To check whether things were working previously, I'll try removing those inserted |
rust-log-analyzer
commented
May 3, 2023
The job Click to see the possible cause of the failure (guessed by this bot) |
Zalathar
commented
May 3, 2023
I've concluded that:
So the regexes in the original Makefile were correct on Linux, and broken on Mac. The changes in #110942 fixed them on Mac, but silently broke them on Linux (which is where they actually get checked in CI). I think I'll need to update the regexes to use |
bors
commented
May 12, 2023
☔ The latest upstream changes (presumably #111493) made this pull request unmergeable. Please resolve the merge conflicts. |
https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Do.20.60needs-profiler-support.60.20tests.20not.20run.20in.20CI.3F
Sorry for the noise; I was having some trouble getting the CI jobs to run at all, and I'm not sure how to politely avoid the auto-notifications.