Skip to content

Return error code from x.ps1 - #111141

Merged
bors merged 1 commit into
rust-lang:masterfrom
ChrisDenton:ps-exitcode
May 4, 2023
Merged

Return error code from x.ps1#111141
bors merged 1 commit into
rust-lang:masterfrom
ChrisDenton:ps-exitcode

Conversation

@ChrisDenton

Copy link
Copy Markdown
Member

Fixes#111136

This works around a bug where ExitCode does not return the exit code. See: https://stackoverflow.com/a/23797762

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 3, 2023
@ChrisDenton

Copy link
Copy Markdown
MemberAuthor

I also added at check that we can get the exit code. So if it does return null again, it'll be a hard error.

@jyn514

Copy link
Copy Markdown
Member

@bors r+ rollup p=1

@bors

bors commented May 3, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 9ea7142 has been approved by jyn514

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2023
@bors

bors commented May 3, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9ea7142 with merge f557a4f...

@borsbors mentioned this pull request May 3, 2023
@bors

bors commented May 4, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing f557a4f to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label May 4, 2023
@bors
bors merged commit f557a4f into rust-lang:masterMay 4, 2023
@rustbotrustbot added this to the 1.71.0 milestone May 4, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f557a4f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
3.2%[3.2%, 3.2%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.3%[-2.3%, -2.3%]1
All ❌✅ (primary)3.2%[3.2%, 3.2%]1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 654.067s -> 655.771s (0.26%)

@ChrisDenton
ChrisDenton deleted the ps-exitcode branch May 4, 2023 05:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x.ps1 does not fail the build

6 participants

@ChrisDenton@rustbot@jyn514@bors@rust-timer@Mark-Simulacrum