Uh oh!
There was an error while loading. Please reload this page.
Return error code from x.ps1 - #111141
Conversation
rustbot
commented
May 3, 2023
(rustbot has picked a reviewer for you, use r? to override) |
ChrisDenton
commented
May 3, 2023
I also added at check that we can get the exit code. So if it does return null again, it'll be a hard error. |
jyn514
commented
May 3, 2023
@bors r+ rollup p=1 |
bors
commented
May 3, 2023
bors
commented
May 3, 2023
bors
commented
May 4, 2023
☀️ Test successful - checks-actions |
rust-timer
commented
May 4, 2023
Finished benchmarking commit (f557a4f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 654.067s -> 655.771s (0.26%) |
Fixes#111136
This works around a bug where
ExitCodedoes not return the exit code. See: https://stackoverflow.com/a/23797762