Skip to content

rustc_middle: Fix opt_item_ident for non-local def ids - #111146

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:decident
May 4, 2023
Merged

rustc_middle: Fix opt_item_ident for non-local def ids#111146
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:decident

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

Noticed while working on #110855.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 3, 2023

@compiler-errorscompiler-errors left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Glad to see some spans were recovered here too.

@compiler-errors

Copy link
Copy Markdown
Contributor

r? @compiler-errors@bors r+ rollup

@bors

bors commented May 3, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 6f6c379 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2023
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
…errors
rustc_middle: Fix `opt_item_ident` for non-local def ids
Noticed while working on rust-lang#110855.
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
…errors
rustc_middle: Fix `opt_item_ident` for non-local def ids
Noticed while working on rust-lang#110855.
This was referenced May 3, 2023
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
…errors
rustc_middle: Fix `opt_item_ident` for non-local def ids
Noticed while working on rust-lang#110855.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2023
…earth
Rollup of 10 pull requests
Successful merges:
- rust-lang#97594 (Implement tuple<->array convertions via `From`)
- rust-lang#105452 (Add cross-language LLVM CFI support to the Rust compiler)
- rust-lang#105695 (Replace generic thread parker with explicit no-op parker)
- rust-lang#110371 (rustdoc: restructure type search engine to pick-and-use IDs)
- rust-lang#110928 (tests: Add tests for LoongArch64)
- rust-lang#110970 (tidy: remove ENTRY_LIMIT maximum checking and set it to 900)
- rust-lang#111104 (Update ICU4X to 1.2)
- rust-lang#111127 (Constify slice flatten method)
- rust-lang#111146 (rustc_middle: Fix `opt_item_ident` for non-local def ids)
- rust-lang#111154 (Use builtin FFX isolation for Fuchsia test runner)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 48c7824 into rust-lang:masterMay 4, 2023
@rustbotrustbot added this to the 1.71.0 milestone May 4, 2023
@petrochenkov
petrochenkov deleted the decident branch February 22, 2025 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov@rustbot@compiler-errors@bors@jackh726