Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure by jieyouxu · Pull Request #112019 · rust-lang/rust

jieyouxu · 2023-05-27T13:47:04Z

Current suggestion for when taking a mutable reference to self in a closure (as an upvar) will produce a machine-applicable suggestion to change the self in the function signature to mut self, but does not account for the specialness of implicit self in that it can already have & and &mut (see #111554). This causes the function signature to become test(&mut mut self) which does not seem desirable.

error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable
--> src/sound_player.rs:870:11
|
869 | pub fn test(&mut self) {
| ---- help: consider changing this to be mutable: `mut self`
870 | || test2(&mut self);
| ^^^^^^^^^ cannot borrow as mutable

This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either ImplicitSelfKind::ImmRef or ImplicitSelfKind::MutRef.

Fixes#111554.

rustbot · 2023-05-27T13:47:11Z

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

jieyouxu · 2023-05-29T06:12:41Z

@rustbot ready

compiler-errors · 2023-06-05T23:10:04Z

@bors r+ rollup

bors · 2023-06-05T23:10:07Z

📌 Commit 57e67e4 has been approved by compiler-errors

It is now in the queue for this repository.

…errors Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure Current suggestion for when taking a mutable reference to `self` in a closure (as an upvar) will produce a machine-applicable suggestion to change the `self` in the function signature to `mut self`, but does not account for the specialness of implicit self in that it can already have `&` and `&mut` (see rust-lang#111554). This causes the function signature to become `test(&mut mut self)` which does not seem desirable. ``` error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable --> src/sound_player.rs:870:11 | 869 | pub fn test(&mut self) { | ---- help: consider changing this to be mutable: `mut self` 870 | || test2(&mut self); | ^^^^^^^^^ cannot borrow as mutable ``` This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either `ImplicitSelfKind::ImmRef` or `ImplicitSelfKind::MutRef`. Fixesrust-lang#111554.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111058 (Correct fortanix LVI test print function) - rust-lang#111369 (Added custom risc32-imac for esp-espidf target) - rust-lang#111962 (Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required `rust-gdb`) - rust-lang#112019 (Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure) - rust-lang#112199 (Fix suggestion for matching struct with `..` on both ends) - rust-lang#112220 (Cleanup some `EarlyBinder::skip_binder()` -> `EarlyBinder::subst_identity()`) - rust-lang#112325 (diagnostics: do not suggest type name tweaks on type-inferred closure args) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2023-05-27T13:47:04Z

Current suggestion for when taking a mutable reference to self in a closure (as an upvar) will produce a machine-applicable suggestion to change the self in the function signature to mut self, but does not account for the specialness of implicit self in that it can already have & and &mut (see #111554). This causes the function signature to become test(&mut mut self) which does not seem desirable.

error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable
--> src/sound_player.rs:870:11
|
869 | pub fn test(&mut self) {
| ---- help: consider changing this to be mutable: `mut self`
870 | || test2(&mut self);
| ^^^^^^^^^ cannot borrow as mutable

This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either ImplicitSelfKind::ImmRef or ImplicitSelfKind::MutRef.

Fixes#111554.

rustbot · 2023-05-27T13:47:11Z

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

jieyouxu · 2023-05-29T06:12:41Z

@rustbot ready

compiler-errors · 2023-06-05T23:10:04Z

@bors r+ rollup

bors · 2023-06-05T23:10:07Z

📌 Commit 57e67e4 has been approved by compiler-errors

It is now in the queue for this repository.

…errors Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure Current suggestion for when taking a mutable reference to `self` in a closure (as an upvar) will produce a machine-applicable suggestion to change the `self` in the function signature to `mut self`, but does not account for the specialness of implicit self in that it can already have `&` and `&mut` (see rust-lang#111554). This causes the function signature to become `test(&mut mut self)` which does not seem desirable. ``` error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable --> src/sound_player.rs:870:11 | 869 | pub fn test(&mut self) { | ---- help: consider changing this to be mutable: `mut self` 870 | || test2(&mut self); | ^^^^^^^^^ cannot borrow as mutable ``` This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either `ImplicitSelfKind::ImmRef` or `ImplicitSelfKind::MutRef`. Fixesrust-lang#111554.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111058 (Correct fortanix LVI test print function) - rust-lang#111369 (Added custom risc32-imac for esp-espidf target) - rust-lang#111962 (Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required `rust-gdb`) - rust-lang#112019 (Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure) - rust-lang#112199 (Fix suggestion for matching struct with `..` on both ends) - rust-lang#112220 (Cleanup some `EarlyBinder::skip_binder()` -> `EarlyBinder::subst_identity()`) - rust-lang#112325 (diagnostics: do not suggest type name tweaks on type-inferred closure args) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2023-05-27T13:47:04Z

Current suggestion for when taking a mutable reference to self in a closure (as an upvar) will produce a machine-applicable suggestion to change the self in the function signature to mut self, but does not account for the specialness of implicit self in that it can already have & and &mut (see #111554). This causes the function signature to become test(&mut mut self) which does not seem desirable.

error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable
--> src/sound_player.rs:870:11
|
869 | pub fn test(&mut self) {
| ---- help: consider changing this to be mutable: `mut self`
870 | || test2(&mut self);
| ^^^^^^^^^ cannot borrow as mutable

This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either ImplicitSelfKind::ImmRef or ImplicitSelfKind::MutRef.

Fixes#111554.

rustbot · 2023-05-27T13:47:11Z

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

jieyouxu · 2023-05-29T06:12:41Z

@rustbot ready

compiler-errors · 2023-06-05T23:10:04Z

@bors r+ rollup

bors · 2023-06-05T23:10:07Z

📌 Commit 57e67e4 has been approved by compiler-errors

It is now in the queue for this repository.

…errors Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure Current suggestion for when taking a mutable reference to `self` in a closure (as an upvar) will produce a machine-applicable suggestion to change the `self` in the function signature to `mut self`, but does not account for the specialness of implicit self in that it can already have `&` and `&mut` (see rust-lang#111554). This causes the function signature to become `test(&mut mut self)` which does not seem desirable. ``` error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable --> src/sound_player.rs:870:11 | 869 | pub fn test(&mut self) { | ---- help: consider changing this to be mutable: `mut self` 870 | || test2(&mut self); | ^^^^^^^^^ cannot borrow as mutable ``` This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either `ImplicitSelfKind::ImmRef` or `ImplicitSelfKind::MutRef`. Fixesrust-lang#111554.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111058 (Correct fortanix LVI test print function) - rust-lang#111369 (Added custom risc32-imac for esp-espidf target) - rust-lang#111962 (Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required `rust-gdb`) - rust-lang#112019 (Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure) - rust-lang#112199 (Fix suggestion for matching struct with `..` on both ends) - rust-lang#112220 (Cleanup some `EarlyBinder::skip_binder()` -> `EarlyBinder::subst_identity()`) - rust-lang#112325 (diagnostics: do not suggest type name tweaks on type-inferred closure args) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2023-05-27T13:47:04Z

Current suggestion for when taking a mutable reference to self in a closure (as an upvar) will produce a machine-applicable suggestion to change the self in the function signature to mut self, but does not account for the specialness of implicit self in that it can already have & and &mut (see #111554). This causes the function signature to become test(&mut mut self) which does not seem desirable.

error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable
--> src/sound_player.rs:870:11
|
869 | pub fn test(&mut self) {
| ---- help: consider changing this to be mutable: `mut self`
870 | || test2(&mut self);
| ^^^^^^^^^ cannot borrow as mutable

This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either ImplicitSelfKind::ImmRef or ImplicitSelfKind::MutRef.

Fixes#111554.

rustbot · 2023-05-27T13:47:11Z

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

jieyouxu · 2023-05-29T06:12:41Z

@rustbot ready

compiler-errors · 2023-06-05T23:10:04Z

@bors r+ rollup

bors · 2023-06-05T23:10:07Z

📌 Commit 57e67e4 has been approved by compiler-errors

It is now in the queue for this repository.

…errors Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure Current suggestion for when taking a mutable reference to `self` in a closure (as an upvar) will produce a machine-applicable suggestion to change the `self` in the function signature to `mut self`, but does not account for the specialness of implicit self in that it can already have `&` and `&mut` (see rust-lang#111554). This causes the function signature to become `test(&mut mut self)` which does not seem desirable. ``` error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable --> src/sound_player.rs:870:11 | 869 | pub fn test(&mut self) { | ---- help: consider changing this to be mutable: `mut self` 870 | || test2(&mut self); | ^^^^^^^^^ cannot borrow as mutable ``` This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either `ImplicitSelfKind::ImmRef` or `ImplicitSelfKind::MutRef`. Fixesrust-lang#111554.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111058 (Correct fortanix LVI test print function) - rust-lang#111369 (Added custom risc32-imac for esp-espidf target) - rust-lang#111962 (Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required `rust-gdb`) - rust-lang#112019 (Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure) - rust-lang#112199 (Fix suggestion for matching struct with `..` on both ends) - rust-lang#112220 (Cleanup some `EarlyBinder::skip_binder()` -> `EarlyBinder::subst_identity()`) - rust-lang#112325 (diagnostics: do not suggest type name tweaks on type-inferred closure args) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2023-05-27T13:47:04Z

Current suggestion for when taking a mutable reference to self in a closure (as an upvar) will produce a machine-applicable suggestion to change the self in the function signature to mut self, but does not account for the specialness of implicit self in that it can already have & and &mut (see #111554). This causes the function signature to become test(&mut mut self) which does not seem desirable.

error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable
--> src/sound_player.rs:870:11
|
869 | pub fn test(&mut self) {
| ---- help: consider changing this to be mutable: `mut self`
870 | || test2(&mut self);
| ^^^^^^^^^ cannot borrow as mutable

This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either ImplicitSelfKind::ImmRef or ImplicitSelfKind::MutRef.

Fixes#111554.

rustbot · 2023-05-27T13:47:11Z

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

jieyouxu · 2023-05-29T06:12:41Z

@rustbot ready

compiler-errors · 2023-06-05T23:10:04Z

@bors r+ rollup

bors · 2023-06-05T23:10:07Z

📌 Commit 57e67e4 has been approved by compiler-errors

It is now in the queue for this repository.

…errors Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure Current suggestion for when taking a mutable reference to `self` in a closure (as an upvar) will produce a machine-applicable suggestion to change the `self` in the function signature to `mut self`, but does not account for the specialness of implicit self in that it can already have `&` and `&mut` (see rust-lang#111554). This causes the function signature to become `test(&mut mut self)` which does not seem desirable. ``` error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable --> src/sound_player.rs:870:11 | 869 | pub fn test(&mut self) { | ---- help: consider changing this to be mutable: `mut self` 870 | || test2(&mut self); | ^^^^^^^^^ cannot borrow as mutable ``` This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either `ImplicitSelfKind::ImmRef` or `ImplicitSelfKind::MutRef`. Fixesrust-lang#111554.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111058 (Correct fortanix LVI test print function) - rust-lang#111369 (Added custom risc32-imac for esp-espidf target) - rust-lang#111962 (Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required `rust-gdb`) - rust-lang#112019 (Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure) - rust-lang#112199 (Fix suggestion for matching struct with `..` on both ends) - rust-lang#112220 (Cleanup some `EarlyBinder::skip_binder()` -> `EarlyBinder::subst_identity()`) - rust-lang#112325 (diagnostics: do not suggest type name tweaks on type-inferred closure args) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2023-05-27T13:47:04Z

Current suggestion for when taking a mutable reference to self in a closure (as an upvar) will produce a machine-applicable suggestion to change the self in the function signature to mut self, but does not account for the specialness of implicit self in that it can already have & and &mut (see #111554). This causes the function signature to become test(&mut mut self) which does not seem desirable.

error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable
--> src/sound_player.rs:870:11
|
869 | pub fn test(&mut self) {
| ---- help: consider changing this to be mutable: `mut self`
870 | || test2(&mut self);
| ^^^^^^^^^ cannot borrow as mutable

This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either ImplicitSelfKind::ImmRef or ImplicitSelfKind::MutRef.

Fixes#111554.

rustbot · 2023-05-27T13:47:11Z

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

jieyouxu · 2023-05-29T06:12:41Z

@rustbot ready

compiler-errors · 2023-06-05T23:10:04Z

@bors r+ rollup

bors · 2023-06-05T23:10:07Z

📌 Commit 57e67e4 has been approved by compiler-errors

It is now in the queue for this repository.

…errors Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure Current suggestion for when taking a mutable reference to `self` in a closure (as an upvar) will produce a machine-applicable suggestion to change the `self` in the function signature to `mut self`, but does not account for the specialness of implicit self in that it can already have `&` and `&mut` (see rust-lang#111554). This causes the function signature to become `test(&mut mut self)` which does not seem desirable. ``` error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable --> src/sound_player.rs:870:11 | 869 | pub fn test(&mut self) { | ---- help: consider changing this to be mutable: `mut self` 870 | || test2(&mut self); | ^^^^^^^^^ cannot borrow as mutable ``` This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either `ImplicitSelfKind::ImmRef` or `ImplicitSelfKind::MutRef`. Fixesrust-lang#111554.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111058 (Correct fortanix LVI test print function) - rust-lang#111369 (Added custom risc32-imac for esp-espidf target) - rust-lang#111962 (Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required `rust-gdb`) - rust-lang#112019 (Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure) - rust-lang#112199 (Fix suggestion for matching struct with `..` on both ends) - rust-lang#112220 (Cleanup some `EarlyBinder::skip_binder()` -> `EarlyBinder::subst_identity()`) - rust-lang#112325 (diagnostics: do not suggest type name tweaks on type-inferred closure args) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2023-05-27T13:47:04Z

Current suggestion for when taking a mutable reference to self in a closure (as an upvar) will produce a machine-applicable suggestion to change the self in the function signature to mut self, but does not account for the specialness of implicit self in that it can already have & and &mut (see #111554). This causes the function signature to become test(&mut mut self) which does not seem desirable.

error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable
--> src/sound_player.rs:870:11
|
869 | pub fn test(&mut self) {
| ---- help: consider changing this to be mutable: `mut self`
870 | || test2(&mut self);
| ^^^^^^^^^ cannot borrow as mutable

This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either ImplicitSelfKind::ImmRef or ImplicitSelfKind::MutRef.

Fixes#111554.

rustbot · 2023-05-27T13:47:11Z

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

jieyouxu · 2023-05-29T06:12:41Z

@rustbot ready

compiler-errors · 2023-06-05T23:10:04Z

@bors r+ rollup

bors · 2023-06-05T23:10:07Z

📌 Commit 57e67e4 has been approved by compiler-errors

It is now in the queue for this repository.

…errors Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure Current suggestion for when taking a mutable reference to `self` in a closure (as an upvar) will produce a machine-applicable suggestion to change the `self` in the function signature to `mut self`, but does not account for the specialness of implicit self in that it can already have `&` and `&mut` (see rust-lang#111554). This causes the function signature to become `test(&mut mut self)` which does not seem desirable. ``` error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable --> src/sound_player.rs:870:11 | 869 | pub fn test(&mut self) { | ---- help: consider changing this to be mutable: `mut self` 870 | || test2(&mut self); | ^^^^^^^^^ cannot borrow as mutable ``` This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either `ImplicitSelfKind::ImmRef` or `ImplicitSelfKind::MutRef`. Fixesrust-lang#111554.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111058 (Correct fortanix LVI test print function) - rust-lang#111369 (Added custom risc32-imac for esp-espidf target) - rust-lang#111962 (Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required `rust-gdb`) - rust-lang#112019 (Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure) - rust-lang#112199 (Fix suggestion for matching struct with `..` on both ends) - rust-lang#112220 (Cleanup some `EarlyBinder::skip_binder()` -> `EarlyBinder::subst_identity()`) - rust-lang#112325 (diagnostics: do not suggest type name tweaks on type-inferred closure args) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2023-05-27T13:47:04Z

Current suggestion for when taking a mutable reference to self in a closure (as an upvar) will produce a machine-applicable suggestion to change the self in the function signature to mut self, but does not account for the specialness of implicit self in that it can already have & and &mut (see #111554). This causes the function signature to become test(&mut mut self) which does not seem desirable.

error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable
--> src/sound_player.rs:870:11
|
869 | pub fn test(&mut self) {
| ---- help: consider changing this to be mutable: `mut self`
870 | || test2(&mut self);
| ^^^^^^^^^ cannot borrow as mutable

This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either ImplicitSelfKind::ImmRef or ImplicitSelfKind::MutRef.

Fixes#111554.

rustbot · 2023-05-27T13:47:11Z

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

jieyouxu · 2023-05-29T06:12:41Z

@rustbot ready

compiler-errors · 2023-06-05T23:10:04Z

@bors r+ rollup

bors · 2023-06-05T23:10:07Z

📌 Commit 57e67e4 has been approved by compiler-errors

It is now in the queue for this repository.

…errors Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure Current suggestion for when taking a mutable reference to `self` in a closure (as an upvar) will produce a machine-applicable suggestion to change the `self` in the function signature to `mut self`, but does not account for the specialness of implicit self in that it can already have `&` and `&mut` (see rust-lang#111554). This causes the function signature to become `test(&mut mut self)` which does not seem desirable. ``` error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable --> src/sound_player.rs:870:11 | 869 | pub fn test(&mut self) { | ---- help: consider changing this to be mutable: `mut self` 870 | || test2(&mut self); | ^^^^^^^^^ cannot borrow as mutable ``` This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either `ImplicitSelfKind::ImmRef` or `ImplicitSelfKind::MutRef`. Fixesrust-lang#111554.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111058 (Correct fortanix LVI test print function) - rust-lang#111369 (Added custom risc32-imac for esp-espidf target) - rust-lang#111962 (Make GDB Python Pretty Printers loadable after spawning GDB, avoiding required `rust-gdb`) - rust-lang#112019 (Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure) - rust-lang#112199 (Fix suggestion for matching struct with `..` on both ends) - rust-lang#112220 (Cleanup some `EarlyBinder::skip_binder()` -> `EarlyBinder::subst_identity()`) - rust-lang#112325 (diagnostics: do not suggest type name tweaks on type-inferred closure args) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jackh726 May 27, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 27, 2023

jieyouxu commented May 27, 2023
View reviewed changes

Comment threadcompiler/rustc_borrowck/src/diagnostics/mutability_errors.rs Outdated

jieyouxu changed the title ~~Don't suggest changing &self and &mut self to be mutable~~Don't suggest changing &self and &mut self in function signature to be mutable when taking &mut self in closureMay 27, 2023

compiler-errors reviewed May 27, 2023
View reviewed changes

Comment threadcompiler/rustc_borrowck/src/diagnostics/mutability_errors.rs Outdated

jieyouxu force-pushed the issue-111554 branch from afa205d to f4aab09Compare May 28, 2023 05:14

compiler-errors reviewed May 29, 2023
View reviewed changes

Comment threadcompiler/rustc_borrowck/src/diagnostics/mutability_errors.rs Outdated

compiler-errors assigned compiler-errors and unassigned jackh726 May 29, 2023

compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2023

Don't suggest changing {ImmRef,MutRef} implicit self to be mutable
57e67e4

jieyouxu force-pushed the issue-111554 branch from f4aab09 to 57e67e4Compare May 29, 2023 05:11

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2023

compiler-errors approved these changes Jun 5, 2023
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2023

matthiaskrgr mentioned this pull request Jun 6, 2023
Rollup of 8 pull requests #112336
Closed

matthiaskrgr mentioned this pull request Jun 6, 2023
Rollup of 7 pull requests #112344
Merged

bors merged commit 21e7463 into rust-lang:masterJun 6, 2023

rustbot added this to the 1.72.0 milestone Jun 6, 2023

jieyouxu deleted the issue-111554 branch December 20, 2024 17:37