Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #112198
Merged
Merged
Conversation
Implemented wrap_item_write Update wrap_item
Fixesrust-lang#111184 by encoding ty::Generator parent substs only.
Signed-off-by: cui fliter <imcusg@gmail.com>
…BoxyUwU Require that const param tys implement `ConstParamTy` 1. Require that const param tys implement `ConstParamTy` instead of using `search_for_adt_const_param_violation` 2. Add `StructuralPartialEq` as a supertrait for `ConstParamTy`, since we need to make sure that we derive *both* `PartialEq` and `Eq` 3. Implement `ConstParamTy` for tuples up to 12 (or whatever the default for tuples is) 4. Add some custom diagnostics to `ConstParamTy` errors, to avoid regressions from (1.). It's still not as great as it could be -- will point out inline in comments. r? `@BoxyUwU`
…piler-errors CFI: Fix cfi with async: transform_ty: unexpected GeneratorWitness(Bi… Fixesrust-lang#111184 by encoding ty::Generator parent substs only.
…aumeGomez Migrate `item_trait_alias` to Askama This PR migrates `item_trait_alias` to Askama Refers rust-lang#108868
Support 128-bit atomics on all x86_64 Apple targets On x86_64, we currently set `max_atomic_width` to 128 only on macOS. https://github.com/rust-lang/rust/blob/ad8304a0d5280de30856b39c19df7b306957e878/compiler/rustc_target/src/spec/x86_64_apple_darwin.rs#L8 However, other x86_64 Apple targets (iOS, tvOS, and watchOS) are also core2+ and support cmpxchg16b. https://github.com/rust-lang/rust/blob/ad8304a0d5280de30856b39c19df7b306957e878/compiler/rustc_target/src/spec/apple_base.rs#L71-L76 ```console # Script to get targets that support cmpxchg16b by default: $ (for target in $(rustc --print target-list); do [[ $target == "x86_64"* ]] && rustc --print cfg --target "$target" | grep -q cmpxchg16b && echo "$target"; done) x86_64-apple-darwin x86_64-apple-ios x86_64-apple-ios-macabi x86_64-apple-tvos x86_64-apple-watchos-sim x86_64h-apple-darwin ``` r? `@Amanieu`
Fix broken link The previous link is no longer accessible. Use the latest link.
…t-GlobalCtxt, r=compiler-errors Improve comments on `TyCtxt` and `GlobalCtxt`. By adding some non-obvious information that took me a little while to figure out. r? `@compiler-errors`
…=est31 Check tuple elements are `Sized` in `offset_of` Fixesrust-lang#112186
compiler-errors
commented
Jun 2, 2023
ContributorAuthor
@bors r+ rollup=never p=𝟟 |
bors
commented
Jun 2, 2023
Collaborator
bors
commented
Jun 2, 2023
Collaborator
bors
commented
Jun 2, 2023
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Jun 2, 2023
Collaborator
📌 Perf builds for each rolled up PR: previous master: 33c3d10128 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Jun 2, 2023
Collaborator
Finished benchmarking commit (8ebf042): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 644.751s -> 644.317s (-0.07%) |
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#111670 (Require that const param tys implement `ConstParamTy`) - rust-lang#111914 (CFI: Fix cfi with async: transform_ty: unexpected GeneratorWitness(Bi…) - rust-lang#112030 (Migrate `item_trait_alias` to Askama) - rust-lang#112150 (Support 128-bit atomics on all x86_64 Apple targets) - rust-lang#112174 (Fix broken link) - rust-lang#112190 (Improve comments on `TyCtxt` and `GlobalCtxt`.) - rust-lang#112193 (Check tuple elements are `Sized` in `offset_of`) Failed merges: - rust-lang#112071 (Group rfcs tests) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ConstParamTy#111670 (Require that const param tys implementConstParamTy)item_trait_aliasto Askama #112030 (Migrateitem_trait_aliasto Askama)TyCtxtandGlobalCtxt. #112190 (Improve comments onTyCtxtandGlobalCtxt.)Sizedinoffset_of#112193 (Check tuple elements areSizedinoffset_of)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup