Skip to content

Fix documentation build on FreeBSD - #112352

Merged
bors merged 1 commit into
rust-lang:masterfrom
dankm:fbsd_doc_fix
Jun 17, 2023
Merged

Fix documentation build on FreeBSD#112352
bors merged 1 commit into
rust-lang:masterfrom
dankm:fbsd_doc_fix

Conversation

@dankm

@dankmdankm commented Jun 6, 2023

Copy link
Copy Markdown
Contributor

After the socket ancillary data implementation was introduced, the documentation build was broken on FreeBSD hosts, add the same workaround as for the existing implementations.

Fixes the doc build after #91793

After the socket ancillary data implementation was introduced, the
build was broken on FreeBSD, add the same workaround as for the
existing implementations.
@rustbot

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 6, 2023
@dankm

dankm commented Jun 6, 2023

Copy link
Copy Markdown
ContributorAuthor

@devnexen, you wrote the original patch. Does this look correct to you?

@devnexen

Copy link
Copy Markdown
Contributor

looks good to me.

@thomcc

Copy link
Copy Markdown
Member

Thanks

@bors r+ rollup

@bors

bors commented Jun 17, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit e99f7ed has been approved by thomcc

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 17, 2023
Fix documentation build on FreeBSD
After the socket ancillary data implementation was introduced, the documentation build was broken on FreeBSD hosts, add the same workaround as for the existing implementations.
Fixes the doc build after rust-lang#91793
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 17, 2023
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#112352 (Fix documentation build on FreeBSD)
- rust-lang#112644 (Correct types in method descriptions of `NonZero*` types)
- rust-lang#112683 (fix ICE on specific malformed asm clobber_abi)
- rust-lang#112707 ([rustdoc] Fix invalid handling of "going back in history" when "go to only search result" setting is enabled)
- rust-lang#112719 (Replace fvdl with ffx, allow test without install)
- rust-lang#112728 (Add `<meta charset="utf-8">` to `-Zdump-mir-spanview` output)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d2120b7 into rust-lang:masterJun 17, 2023
@rustbotrustbot added this to the 1.72.0 milestone Jun 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@dankm@rustbot@devnexen@thomcc@bors