Skip to content

Add a test for #105709 - #112389

Merged
bors merged 1 commit into
rust-lang:masterfrom
TaKO8Ki:issue-105709
Jun 8, 2023
Merged

Add a test for #105709#112389
bors merged 1 commit into
rust-lang:masterfrom
TaKO8Ki:issue-105709

Conversation

@TaKO8Ki

@TaKO8KiTaKO8Ki commented Jun 7, 2023

Copy link
Copy Markdown
Member

Closes#105709

@rustbot

rustbot commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 7, 2023
compiler-errors
compiler-errors reviewed Jun 7, 2023
View reviewed changes
Comment threadtests/ui/const-generics/generic_const_exprs/issue-105709.rs Outdated
Comment threadtests/ui/const-generics/generic_const_exprs/issue-105709.rs Outdated

@compiler-errorscompiler-errorsJun 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a better issue name. Perhaps something like inline-const-in-const-generic-default or something?

@compiler-errors

compiler-errors commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Squash this into one commit, then r=me.

@TaKO8Ki
TaKO8Kiforce-pushed the issue-105709 branch 2 times, most recently from 9009d14 to 7a3e569CompareJune 7, 2023 18:09
@TaKO8Ki
add a test forrust-lang#105709
5e57e27
replace build with check
Co-authored-by: Michael Goulet <michael@errs.io>
use appropriate test name
@Dylan-DPC

Dylan-DPC commented Jun 8, 2023

Copy link
Copy Markdown
Member

@bors r=compiler-errors rollup=always

@bors

bors commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 5e57e27 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2023
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jun 8, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2023
@bors
Auto merge ofrust-lang#112415- GuillaumeGomez:rollup-5pa9frd, r=Gui…
e740925
…llaumeGomez
Rollup of 9 pull requests
Successful merges:
- rust-lang#112034 (Migrate `item_opaque_ty` to Askama)
- rust-lang#112179 (Avoid passing --cpu-features when empty)
- rust-lang#112309 (bootstrap: remove dependency `is-terminal`)
- rust-lang#112388 (Migrate GUI colors test to original CSS color format)
- rust-lang#112389 (Add a test for rust-lang#105709)
- rust-lang#112392 (Fix ICE for while loop with assignment condition with LHS place expr)
- rust-lang#112394 (Remove accidental comment)
- rust-lang#112396 (Track more diagnostics in `rustc_expand`)
- rust-lang#112401 (Don't `use compile_error as print`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 5b7eba6 into rust-lang:masterJun 8, 2023
@rustbotrustbot added this to the 1.72.0 milestone Jun 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@compiler-errorscompiler-errorscompiler-errors left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errorscompiler-errors

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.72.0

Development

Successfully merging this pull request may close these issues.

ICE: type parameter out of range when substituting

6 participants

@TaKO8Ki@rustbot@compiler-errors@Dylan-DPC@bors@oli-obk