Better diagnostics for dlltool errors. by jfgoog · Pull Request #112591 · rust-lang/rust

jfgoog · 2023-06-13T16:21:09Z

When dlltool fails, show the full command that was executed. In particular, llvm-dlltool is not very helpful, printing a generic usage message rather than what actually went wrong, so stdout and stderr aren't of much use when troubleshooting.

rustbot · 2023-06-13T16:21:17Z

r? @fee1-dead

(rustbot has picked a reviewer for you, use r? to override)

jfgoog · 2023-06-13T16:23:14Z

Example of output:

error: Dlltool could not create import library with /usr/local/google/home/jamesfarrell/src/rust-toolchain/prebuilts/clang/host/linux-x86/clang-r487747c/bin/llvm-dlltool -d /tmp/rustcNiX2JN/kernel32.def -D kernel32.dll -l /tmp/rustcNiX2JN/kernel32.lib -m i386:x86-64 -f --64 --no-leading-underscore --temp-prefix /tmp/rustcNiX2JN/kernel32.dll:
OVERVIEW: llvm-dlltool
USAGE: llvm-dlltool [options] file...
OPTIONS:
-D <value> Specify the input DLL Name
-d <value> Input .def File
-f <value> Assembler Flags
-k Kill @n Symbol from export
-l <value> Generate an import lib
-m <value> Set target machine
-S <value> Assembler
TARGETS: i386, i386:x86-64, arm, arm64

(Note that the underlying problem causing this particular error is that llvm-dlltool doesn't support --temp-prefix, which I intend to address separately.)

fee1-dead · 2023-06-16T15:56:44Z

I'm not familiar with this.

r? compiler

WaffleLapkin

Can you squash the commits together?

jfgoog · 2023-06-20T14:37:01Z

Squashed. Thanks for the review.

WaffleLapkin

Thanks!

WaffleLapkin · 2023-06-20T15:22:04Z

@bors r+ rollup

bors · 2023-06-20T15:22:06Z

📌 Commit 4bdba91 has been approved by WaffleLapkin

It is now in the queue for this repository.

… r=WaffleLapkin Better diagnostics for dlltool errors. When dlltool fails, show the full command that was executed. In particular, llvm-dlltool is not very helpful, printing a generic usage message rather than what actually went wrong, so stdout and stderr aren't of much use when troubleshooting.

compiler-errors · 2023-06-20T19:59:16Z

@bors r- failed in rollup: #112851 (comment)

WaffleLapkin · 2023-06-22T14:05:44Z

@jfgoog you need to find a way to bless the test in such a way, it passes both in CI and locally (this might be non-trivial, given that the test includes paths...)

jfgoog · 2023-06-22T15:35:38Z

Done. I'm not able to test locally, since I'm building on Linux and using llvm-dlltool, which produces different output, which is the entire reason for this change.

Is there a way to trigger the build that failed without sending to submit queue?

WaffleLapkin · 2023-06-26T09:09:17Z

@jfgoog you should be able to add the x86_64-mingw to CI-on-pull-requests, but I'm not sure about the details.

@bors r+ rollup=never

bors · 2023-06-26T09:09:19Z

📌 Commit d1f68ea has been approved by WaffleLapkin

It is now in the queue for this repository.

bors · 2023-07-09T05:46:19Z

💔 Test failed - checks-actions

Noratrieb · 2023-07-09T07:45:23Z

This looks like a legitimate failure, probably needs some blessing.

jfgoog · 2023-07-17T15:38:50Z

I've been on vacation. Will take a look soon.

When dlltool fails, show the full command that was executed. In particular, llvm-dlltool is not very helpful, printing a generic usage message rather than what actually went wrong, so stdout and stderr aren't of much use when troubleshooting.

jfgoog · 2023-07-18T14:29:14Z

OK, I think it's fixed, but I unfortunately don't have a good way to test locally, as I mentioned previously.

WaffleLapkin · 2023-07-18T15:17:05Z

@bors r+

Let's try it

bors · 2023-07-18T15:17:07Z

📌 Commit c59b823 has been approved by WaffleLapkin

It is now in the queue for this repository.

bors · 2023-07-18T16:40:55Z

⌛ Testing commit c59b823 with merge 75bcdc515f778584d42b0050cc105ab12d5a0c98...

bors · 2023-07-18T16:43:34Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-07-18T16:46:35Z

The job dist-arm-linux failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

Caused by:
failed to query replaced source registry `crates-io`
Caused by:
download of cm/ak/cmake failed
Caused by:
Caused by:
failed to get successful HTTP response from `https://index.crates.io/cm/ak/cmake` (18.165.83.65), got 421
debug headers:
x-amz-cf-pop: IAD12-P1
x-cache: Error from cloudfront
x-amz-cf-pop: IAD55-P3
x-amz-cf-id: LM2aafdvxyhixbf2HJOaAisxMiZe_5-jGUvdbgUa6hysujfWYO5VqQ==
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<HTML><HEAD><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<TITLE>ERROR: The request could not be satisfied</TITLE>
</HEAD><BODY>
---
[TIMING] compile::Sysroot { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, force_recompile: false } -- 0.000
[TIMING] builder::Builder::sysroot_libdir::Libdir { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target: x86_64-unknown-linux-gnu } -- 0.000
##[group]Building stage0 library artifacts (x86_64-unknown-linux-gnu)
Updating crates.io index
error: failed to get `shell-escape` as a dependency of package `clippy_dev v0.0.1 (/checkout/src/tools/clippy/clippy_dev)`
Caused by:
failed to query replaced source registry `crates-io`
Caused by:
Caused by:
download of sh/el/shell-escape failed
Caused by:
Caused by:
failed to get successful HTTP response from `https://index.crates.io/sh/el/shell-escape` (18.165.83.98), got 421
debug headers:
x-amz-cf-pop: IAD12-P1
x-cache: Error from cloudfront
x-amz-cf-pop: IAD55-P3
x-amz-cf-id: 4NHRuTpfPbKJKpjf-GMiOpboRXbyfxAbOQtyJ3y7yWB9lhezenp9nQ==
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<HTML><HEAD><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<TITLE>ERROR: The request could not be satisfied</TITLE>
</HEAD><BODY>

WaffleLapkin · 2023-07-19T07:13:50Z

@bors retry crates.io error

bors · 2023-07-19T07:27:54Z

⌛ Testing commit c59b823 with merge 77e24f9...

bors · 2023-07-19T09:13:28Z

☀️ Test successful - checks-actions
Approved by: WaffleLapkin
Pushing 77e24f9 to master...

rust-timer · 2023-07-19T10:30:15Z

Finished benchmarking commit (77e24f9): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.4%	[5.9%, 7.2%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.5%, -2.3%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.114s -> 647.294s (0.03%)

rustbot assigned fee1-dead Jun 13, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 13, 2023

This comment has been minimized.
Sign in to view

rustbot assigned WaffleLapkin and unassigned fee1-dead Jun 16, 2023

WaffleLapkin approved these changes Jun 19, 2023
View reviewed changes

jfgoog force-pushed the better-dlltool-diagnostics branch from 4ca05d1 to 4bdba91Compare June 20, 2023 14:36

WaffleLapkin approved these changes Jun 20, 2023
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2023

compiler-errors mentioned this pull request Jun 20, 2023
Rollup of 6 pull requests #112851
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2023

jfgoog force-pushed the better-dlltool-diagnostics branch from 4bdba91 to d1f68eaCompare June 22, 2023 15:31

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2023

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2023

Noratrieb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2023

Better diagnostics for dlltool errors.
c59b823
When dlltool fails, show the full command that was executed. In particular, llvm-dlltool is not very helpful, printing a generic usage message rather than what actually went wrong, so stdout and stderr aren't of much use when troubleshooting.

jfgoog force-pushed the better-dlltool-diagnostics branch from d1f68ea to c59b823Compare July 17, 2023 20:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 19, 2023

bors merged commit 77e24f9 into rust-lang:masterJul 19, 2023

rustbot added this to the 1.73.0 milestone Jul 19, 2023

Uh oh!

Uh oh!

Conversation

jfgoog commented Jun 13, 2023

Uh oh!

rustbot commented Jun 13, 2023

Uh oh!

jfgoog commented Jun 13, 2023

Uh oh!

This comment has been minimized.

fee1-dead commented Jun 16, 2023

Uh oh!

WaffleLapkin left a comment

Choose a reason for hiding this comment

Uh oh!

jfgoog commented Jun 20, 2023

Uh oh!

WaffleLapkin left a comment

Choose a reason for hiding this comment

Uh oh!

WaffleLapkin commented Jun 20, 2023

Uh oh!

bors commented Jun 20, 2023

Uh oh!

compiler-errors commented Jun 20, 2023

Uh oh!

WaffleLapkin commented Jun 22, 2023

Uh oh!

jfgoog commented Jun 22, 2023

Uh oh!

WaffleLapkin commented Jun 26, 2023

Uh oh!

bors commented Jun 26, 2023

Uh oh!

This comment has been minimized.

bors commented Jul 9, 2023

Uh oh!

Noratrieb commented Jul 9, 2023

Uh oh!

jfgoog commented Jul 17, 2023

Uh oh!

jfgoog commented Jul 18, 2023

Uh oh!

WaffleLapkin commented Jul 18, 2023

Uh oh!

bors commented Jul 18, 2023

Uh oh!

bors commented Jul 18, 2023

Uh oh!

bors commented Jul 18, 2023

Uh oh!

rust-log-analyzer commented Jul 18, 2023

Uh oh!

WaffleLapkin commented Jul 19, 2023

Uh oh!

bors commented Jul 19, 2023

Uh oh!

bors commented Jul 19, 2023

Uh oh!

rust-timer commented Jul 19, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants