Rollup of 7 pull requests by matthiaskrgr · Pull Request #112625 · rust-lang/rust

matthiaskrgr · 2023-06-14T16:10:33Z

Successful merges:

loongarch64-none*: Remove environment component from llvm target #112584 (loongarch64-none*: Remove environment component from llvm target)
Introduce a Stable trait to translate MIR to SMIR #112600 (Introduce a Stable trait to translate MIR to SMIR)
Improve docs/clean up negative overlap functions #112605 (Improve docs/clean up negative overlap functions)
Error on unconstrained lifetime in RPITIT #112611 (Error on unconstrained lifetime in RPITIT)
Fix explicit-outlives-requirements lint span #112612 (Fix explicit-outlives-requirements lint span)
Fix rustdoc-gui tests on Windows #112613 (Fix rustdoc-gui tests on Windows)
Fix small typo #112620 (Fix small typo)

r? @ghost
@rustbot modify labels: rollup

I was wondering if this would be a bit cleaner.

…i-test

…a `/`)

…enkov loongarch64-none*: Remove environment component from llvm target A warning is reported when the LLVM triple-implied ABI conflicts with the provided target-abi. ``` warning: triple-implied ABI conflicts with provided target-abi ‘lp64s', using target-abi ``` Specifically, the ABI hint comes from the environment component of the triple. When only the target-abi is provided and no environment, there is no conflict. This PR removes the environment component from the LLVM target name of the `loongarch64-unknown-none-softfloat` target.

Introduce a `Stable` trait to translate MIR to SMIR This PR introduces a trait `Stable` which defines a type `T` and a `stable()` method to convert the current type to its stable MIR version. This change is just an implementation detail, and I wanted to get some feedback to whether it would be cleaner than having the `rustc_<type>_to_<type>()` methods for every type we translate to SMIR. r? `@oli-obk` r? `@spastorino`

…pastorino Improve docs/clean up negative overlap functions Clean up some functions in ways that should not affect behavior, change some names to be clearer (`negative_impl` and `implicit_negative` are not really clear imo), and add some documentation examples. r? `@spastorino`

…n-rpitit, r=oli-obk Error on unconstrained lifetime in RPITIT Fixesrust-lang#109468 The only thing is that I had to split `tests/ui/impl-trait/in-trait/method-signature-matches.rs` into a bunch of different revisions because some error aren't being emitted if all the different examples are all together in one file 🤔 r? `@oli-obk` just because i know you'll review it, feel free to re-roll

…errors Fix explicit-outlives-requirements lint span Fixesrust-lang#105150 which caused the span reported by the explicit-outlives-requirements lint to be incorrect when 1) the lint should suggest the entire where clause to be removed and 2) there are inline bounds present that are not inferable outlives requirements In particular, this would cause rustfix to leave a dangling empty where clause.

…s, r=notriddle Fix rustdoc-gui tests on Windows The browser-ui-test update contains fixes needed for backslash handling (they were not correctly escaped). Since we have a mix of slash and backslash in some tests, I replaced `DOC_FOLDER` variable backslashes with slashes. And finally it seemed like the unicode escaped wasn't much appreciated on Windows for some reason so I used the character directly. cc `@klensy` r? `@notriddle`

Fix small typo Fixes a small typo in the [`Successors`](https://doc.rust-lang.org/std/iter/struct.Successors.html) documentation.

matthiaskrgr · 2023-06-14T16:11:06Z

@bors r+ rollup=never p=7

bors · 2023-06-14T16:11:08Z

📌 Commit 3616388 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-06-14T20:20:44Z

⌛ Testing commit 3616388 with merge 8c74a5d...

bors · 2023-06-14T23:18:34Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 8c74a5d to master...

rust-timer · 2023-06-14T23:20:34Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#112620	d71421ee635e40955ba82a24cc440b508b9953a5
#112613	361f269332cd7e897df385972f9d13842b1bb9ae
#112612	76a515163af020a51f7d857c7f8b7dc8c93c1cfa
#112611	7641931643b3320c50656841c2d630281ce2b505
#112605	c13bdbc1cacd64080c71c59dc6571385d1176395
#112600	31a90fdf3f5e89176b9b3d84616a701312ecc409
#112584	91de88d553289a24a2c70141276f38855e06efa6

previous master: 0b475c705f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-06-15T00:33:34Z

Finished benchmarking commit (8c74a5d): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	4
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.4%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[1.5%, 1.5%]	1
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.904s -> 649.711s (-0.03%)

rylev · 2023-06-21T07:21:31Z

Seems like this was a blip in the bitmaps test which corrected itself in the next run.

@rustbot label: +perf-regression-triaged

heiherand others added 17 commits June 13, 2023 20:24

loongarch64-none*: Remove environment component from llvm target
22a4525

Use a Stable trait to translate mir -> smir
af4040a
I was wondering if this would be a bit cleaner.

Improve docs/clean up negative overlap functions
9e21052

Error on unconstrained lifetime in RPITIT
bc78d0c

Fix explicit-outlives-requirements lint span
72531b7

Update browser-ui-test version to 0.16.7
2f9fac0

Transform backslash into slashes in DOC_FOLDER variable for browser-u…
fd4320c
…i-test

Replace unicode value with character in shortcuts.goml test
df9a46f

Fix href attribute value check on Windows (DOC_PATH lacks an extr…
fced638
…a `/`)

Fix typo
cb093fc

Rollup merge ofrust-lang#112620- AntoniosBarotsis:master, r=Nilstrieb
3616388
Fix small typo Fixes a small typo in the [`Successors`](https://doc.rust-lang.org/std/iter/struct.Successors.html) documentation.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 14, 2023

bors merged commit 8c74a5d into rust-lang:masterJun 14, 2023

rustbot added this to the 1.72.0 milestone Jun 14, 2023

bors mentioned this pull request Jun 15, 2023
Better error for non const PartialEq call generated by match#112232
Merged

rustbot added the perf-regression Performance regression. label Jun 15, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 21, 2023

matthiaskrgr deleted the rollup-jcobj3g branch March 16, 2024 18:19

Navigation Menu

Uh oh!

Uh oh!

Rollup of 7 pull requests - #112625

Rollup of 7 pull requests#112625
bors merged 17 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-jcobj3g

matthiaskrgr commented Jun 14, 2023

Uh oh!

matthiaskrgr commented Jun 14, 2023

Uh oh!

bors commented Jun 14, 2023

Uh oh!

bors commented Jun 14, 2023

Uh oh!

bors commented Jun 14, 2023

Uh oh!

rust-timer commented Jun 14, 2023

Uh oh!

rust-timer commented Jun 15, 2023

Uh oh!

rylev commented Jun 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented Jun 14, 2023

Uh oh!

matthiaskrgr commented Jun 14, 2023

Uh oh!

bors commented Jun 14, 2023

Uh oh!

bors commented Jun 14, 2023

Uh oh!

bors commented Jun 14, 2023

Uh oh!

rust-timer commented Jun 14, 2023

Uh oh!

rust-timer commented Jun 15, 2023

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rylev commented Jun 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants