Uh oh!
There was an error while loading. Please reload this page.
Allow comparing Boxes with different allocators - #112628
Merged
Merged
Conversation
rustbot
commented
Jun 14, 2023
Collaborator
(rustbot has picked a reviewer for you, use r? to override) |
gootorov
commented
Jun 14, 2023
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
gootorovforce-pushed
the
box_alloc_partialeq
branch
from
June 14, 2023 17:37
9598a11 to
5ca1a6aCompareUh oh!
There was an error while loading. Please reload this page.
gootorovforce-pushed
the
box_alloc_partialeq
branch
from
June 14, 2023 18:18
5ca1a6a to
3d3c6cdComparegootorovforce-pushed
the
box_alloc_partialeq
branch
from
June 18, 2023 03:22
3d3c6cd to
001b081Comparegootorov
commented
Jun 18, 2023
ContributorAuthor
Corresponding ACP: rust-lang/libs-team#241 |
joshtriplett
commented
Jun 27, 2023
Member
@bors r+ rollup |
bors
commented
Jun 27, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 27, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#112207 (Add trustzone and virtualization target features for aarch32.) - rust-lang#112454 (Make compiletest aware of targets without dynamic linking) - rust-lang#112628 (Allow comparing `Box`es with different allocators) - rust-lang#112692 (Provide more context for `rustc +nightly -Zunstable-options` on stable) - rust-lang#112972 (Make `UnwindAction::Continue` explicit in MIR dump) - rust-lang#113020 (Add tests impl via obj unless denied) - rust-lang#113084 (Simplify some conditions) - rust-lang#113103 (Normalize types when applying uninhabited predicate.) r? `@ghost` `@rustbot` modify labels: rollup
Contributor
This PR appears to have introduced a regression. The following program compiles before this PR, but not after: #[derive(Debug,PartialEq)]structExpr;#[allow(dead_code)]fnfrom_exprs(exprs:Vec<Box<Expr>>){debug_assert_ne!(exprs, vec![],"exprs must not be empty");}E.g.: I noticed this while trying to build |
smoelius added a commit
to trailofbits/necessist
that referenced
this pull request
Jul 3, 2023
Until the following is resolved: rust-lang/rust#112628 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, comparing
Boxes over different allocators is not allowed:This PR lifts this limitation