Skip to content

CI: merge mingw test CI jobs - #112645

Merged
bors merged 1 commit into
rust-lang:masterfrom
Kobzol:ci-mingw-merge
Jun 18, 2023
Merged

CI: merge mingw test CI jobs#112645
bors merged 1 commit into
rust-lang:masterfrom
Kobzol:ci-mingw-merge

Conversation

@Kobzol

@KobzolKobzol commented Jun 15, 2023

Copy link
Copy Markdown
Member

Same as #112633, but for mingw. From the logs it looks like the runner spends 40 minutes compiling rustc, and then 10/20 minutes running tests. It seems wasteful to split that into two jobs.

CI run: https://github.com/rust-lang/rust/actions/runs/5275702134/jobs/9541479343?pr=112645

r? @jyn514

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 15, 2023
@Kobzol
Kobzol marked this pull request as ready for review June 15, 2023 09:07
@jyn514

Copy link
Copy Markdown
Member

don't have time for reviews.

r? infra-ci

@Kobzol

Copy link
Copy Markdown
MemberAuthor

I applied jyn's suggestion to test both entrypoints (x and bootstrap.py).

r? @pietroalbini

@Kobzol
Kobzol marked this pull request as draft June 18, 2023 07:50
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Converting to draft until #112668 is resolved.

Comment threadsrc/bootstrap/mk/Makefile.in Outdated
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Performed the same change as in #112668, testing if it works on PR.

@rust-log-analyzer

This comment has been minimized.

@Kobzol
Kobzolforce-pushed the ci-mingw-merge branch 2 times, most recently from b5d0737 to f3a4cf1CompareJune 18, 2023 19:28
@Kobzol
Kobzol marked this pull request as ready for review June 18, 2023 19:28
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Good, tests now pass.

@rustbot ready

@emilyalbini

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 18, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit f3a4cf1 has been approved by pietroalbini

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2023
@bors

bors commented Jun 18, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f3a4cf1 with merge 2d0aa57...

@bors

bors commented Jun 18, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 2d0aa57 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 18, 2023
@bors
bors merged commit 2d0aa57 into rust-lang:masterJun 18, 2023
@rustbotrustbot added this to the 1.72.0 milestone Jun 18, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (2d0aa57): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
0.8%[0.7%, 0.8%]3
Regressions ❌
(secondary)
0.7%[0.6%, 0.7%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.8%[0.7%, 0.8%]3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)--0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.1%[-2.1%, -2.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.1%[-2.1%, -2.1%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 656.699s -> 657.452s (0.11%)

@rustbotrustbot added the perf-regression Performance regression. label Jun 18, 2023
@nnethercote

Copy link
Copy Markdown
Contributor

This must be noise, Linux wasn't affected.

@rustbot label: +perf-regression-triaged

@rustbotrustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 19, 2023
@Kobzol
Kobzol deleted the ci-mingw-merge branch June 19, 2023 05:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Kobzol@jyn514@rust-log-analyzer@emilyalbini@bors@rust-timer@nnethercote@Mark-Simulacrum@rustbot