Uh oh!
There was an error while loading. Please reload this page.
CI: merge mingw test CI jobs - #112645
Conversation
jyn514
commented
Jun 15, 2023
don't have time for reviews. r? infra-ci |
Kobzol
commented
Jun 15, 2023
I applied jyn's suggestion to test both entrypoints ( |
Kobzol
commented
Jun 18, 2023
Converting to draft until #112668 is resolved. |
Uh oh!
There was an error while loading. Please reload this page.
Kobzol
commented
Jun 18, 2023
Performed the same change as in #112668, testing if it works on PR. |
This comment has been minimized.
This comment has been minimized.
b5d0737 to
f3a4cf1CompareKobzol
commented
Jun 18, 2023
Good, tests now pass. @rustbot ready |
emilyalbini
commented
Jun 18, 2023
@bors r+ |
bors
commented
Jun 18, 2023
bors
commented
Jun 18, 2023
bors
commented
Jun 18, 2023
☀️ Test successful - checks-actions |
rust-timer
commented
Jun 18, 2023
Finished benchmarking commit (2d0aa57): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 656.699s -> 657.452s (0.11%) |
nnethercote
commented
Jun 19, 2023
This must be noise, Linux wasn't affected. @rustbot label: +perf-regression-triaged |
Same as #112633, but for
mingw. From the logs it looks like the runner spends 40 minutes compilingrustc, and then10/20minutes running tests. It seems wasteful to split that into two jobs.CI run: https://github.com/rust-lang/rust/actions/runs/5275702134/jobs/9541479343?pr=112645
r? @jyn514