Require TAITs to be mentioned in the signatures of functions that register hidden types for them by oli-obk · Pull Request #112652 · rust-lang/rust

oli-obk · 2023-06-15T10:13:44Z

This implements the lang team decision from the TAIT design meeting.

rustbot · 2023-06-15T10:13:52Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot · 2023-06-15T10:13:56Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @TaKO8Ki

lcnr

not sure if this is ready yet and it might be nice to move the cleanup into a separate PR which can be approved separately.

My understanding was that we want to only allow defining uses for things in signatures, but make other uses in the same module ambiguous. This is not what's implemented in 9523613a1dcadfcd1105da1ee86c18879640976b afaict. I would expect us to implement this by keep the current logic for trait solving and checking in type_of whether any defining use was outside of the "currently stable" defining uses, if not error and suggest moving the function out of the defining module or whatever.

oli-obk · 2023-06-21T08:21:11Z

@rustbot author

…-in-OpaqueTypeCollector, r=oli-obk Don't substitute a GAT that has mismatched generics in `OpaqueTypeCollector` Fixesrust-lang#111828 I didn't put up minimized UI tests for rust-lang#112510 or rust-lang#112873 because they'd minimize to literally the same code, but with different substs on the trait/impl. I don't think that warrants duplicate tests given the nature of the fix. r? `@oli-obk` ---- Side-note: I checked, and this isn't fixed by rust-lang#112652 -- I think we discussed whether or not that PR fixed it either intentionally or by accident. The code here isn't really touched by that PR either as far as I can tell? Also, sorry, did some other drive-bys. Hope it doesn't make rebasing rust-lang#112652 too difficult 😅

bors · 2023-06-22T09:27:36Z

☔ The latest upstream changes (presumably #112914) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2023-06-26T17:08:29Z

+ if !self.tcx.opaque_types_defined_by(item_def_id).contains(&self.def_id) {
+ self.tcx.sess.emit_err(TaitForwardCompat {
+ span: hidden_type.span,
+ item_span: self
+ .tcx
+ .def_ident_span(item_def_id)
+ .unwrap_or_else(|| self.tcx.def_span(item_def_id)),
+ });
+ }


This is the main change of this PR. We double check that any item that produces hidden types also has the corresponding opaque type in its signature

oli-obk · 2023-06-26T17:09:50Z

@rustbot ready

bors · 2023-07-07T09:18:00Z

☔ The latest upstream changes (presumably #113429) made this pull request unmergeable. Please resolve the merge conflicts.

…ister hidden types for them

…ntermediate `Vec` first

oli-obk · 2023-07-07T13:58:30Z

@bors r=compiler-errors

bors · 2023-07-07T13:58:32Z

📌 Commit c3004a7 has been approved by compiler-errors

It is now in the queue for this repository.

…er-errors Require TAITs to be mentioned in the signatures of functions that register hidden types for them r? `@lcnr` `@compiler-errors` This implements the lang team decision from [the TAIT design meeting](https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/design.20meeting.202023-05-31.20TAITs/near/362518164).

bors · 2023-07-08T03:22:57Z

⌛ Testing commit c3004a7 with merge d4096e0...

bors · 2023-07-08T06:00:03Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing d4096e0 to master...

rust-timer · 2023-07-08T07:15:42Z

Finished benchmarking commit (d4096e0): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-5.0%, -1.0%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[0.8%, 0.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 655.621s -> 656.508s (0.14%)

rustbot assigned lcnr Jun 15, 2023

This comment has been minimized.
Sign in to view

oli-obk force-pushed the tait_only_in_sig branch from 9f5c836 to ca8ff0eCompare June 15, 2023 13:54

This comment has been minimized.
Sign in to view

oli-obk force-pushed the tait_only_in_sig branch from abbc6da to a078624Compare June 19, 2023 09:38

This comment has been minimized.
Sign in to view

oli-obk force-pushed the tait_only_in_sig branch from cb6836b to efeee50Compare June 19, 2023 12:43

oli-obk mentioned this pull request Jun 20, 2023
Require a #[defines] attribute for type-alias-impl-trait in order for a function to be able to register hidden types. #110010
Closed
6 tasks

lcnr reviewed Jun 20, 2023
View reviewed changes

This was referenced Jun 21, 2023
ICE: impl_trait_in_assoc_type: expected const for .. but found Lifetime(ReLateBound(..#112873
Closed
Don't substitute a GAT that has mismatched generics in OpaqueTypeCollector#112876
Merged

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2023

oli-obk force-pushed the tait_only_in_sig branch from 78f41ed to b8345acCompare June 26, 2023 15:26

This comment has been minimized.
Sign in to view

oli-obk force-pushed the tait_only_in_sig branch from b8345ac to 5bdadf5Compare June 26, 2023 15:53

oli-obk commented Jun 26, 2023
View reviewed changes

Require TAITs to be mentioned in the signatures of functions that reg…
4c99872
…ister hidden types for them

oli-obk force-pushed the tait_only_in_sig branch from 5872bed to 6edda79Compare July 7, 2023 13:16

oli-obk added 10 commits July 7, 2023 13:17

Remove normalization from opaque_types_defined_by
907f97e

We don't need to track binders if we aren't normalizing
2f89c96

liar liar find_taits_declared_in_body on fire
a3ca139

Remove one layer of nested matching on the same thing
af9dcf7

Move some logic into a method on OpaqueTypeCollector
b07d27c

Collect nested items immediately instead of collecting them into an i…
18f3d86
…ntermediate `Vec` first

Only match on the DefKind once.
dcacfe7

Add regression test
ef52dc7

Fix one layer of closures not being able to constrain opaque types
b549ba1

Treat closures as part of their parent
c3004a7

oli-obk force-pushed the tait_only_in_sig branch from 6edda79 to c3004a7Compare July 7, 2023 13:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2023

GuillaumeGomez mentioned this pull request Jul 7, 2023
Rollup of 6 pull requests #113454
Closed

compiler-errors mentioned this pull request Jul 7, 2023
On nightly, dump ICE backtraces to disk #108714
Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 8, 2023

bors merged commit d4096e0 into rust-lang:masterJul 8, 2023

rustbot added this to the 1.72.0 milestone Jul 8, 2023

bors mentioned this pull request Jul 8, 2023
Replace RPITIT current impl with new strategy that lowers as a GAT #112988
Merged

oli-obk deleted the tait_only_in_sig branch July 8, 2023 16:13

Uh oh!

Uh oh!

Conversation

oli-obk commented Jun 15, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 15, 2023

Uh oh!

rustbot commented Jun 15, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lcnr left a comment

Choose a reason for hiding this comment

Uh oh!

oli-obk commented Jun 21, 2023

Uh oh!

bors commented Jun 22, 2023

Uh oh!

This comment has been minimized.

oli-obkJun 26, 2023

Choose a reason for hiding this comment

Uh oh!

oli-obk commented Jun 26, 2023

Uh oh!

bors commented Jul 7, 2023

Uh oh!

oli-obk commented Jul 7, 2023

Uh oh!

bors commented Jul 7, 2023

Uh oh!

bors commented Jul 8, 2023

Uh oh!

bors commented Jul 8, 2023

Uh oh!

rust-timer commented Jul 8, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

oli-obk commented Jun 15, 2023•
edited
Loading