Skip to content

Migrate some rustc_builtin_macros to SessionDiagnostic - #112795

Merged
bors merged 2 commits into
rust-lang:masterfrom
He1pa:translation_builtin_macros
Jun 30, 2023
Merged

Migrate some rustc_builtin_macros to SessionDiagnostic#112795
bors merged 2 commits into
rust-lang:masterfrom
He1pa:translation_builtin_macros

Conversation

@He1pa

@He1paHe1pa commented Jun 19, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Part of #100717.

@rustbot label +A-translation

@rustbot

rustbot commented Jun 19, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Jun 19, 2023
@He1pa
He1paforce-pushed the translation_builtin_macros branch from df0725c to 1b73708CompareJune 21, 2023 10:38
@He1paHe1pa changed the title Migrate rustc_builtin_macros to SessionDiagnosticMigrate some rustc_builtin_macros to SessionDiagnosticJun 21, 2023
@He1pa
He1pa marked this pull request as ready for review June 21, 2023 10:41
@He1pa
He1paforce-pushed the translation_builtin_macros branch 2 times, most recently from 3e56f34 to 83011abCompareJune 21, 2023 11:09
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@He1pa
He1paforce-pushed the translation_builtin_macros branch from 83011ab to ba2f003CompareJune 21, 2023 11:53
@He1pa

He1pa commented Jun 21, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@rustbot r?davidtwco

@rustbot

rustbot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

Failed to set assignee to [cjgillot]: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot

rustbot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

Failed to set assignee to [davidtwco]: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@cjgillot

cjgillot commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

r? @davidtwco

@rustbotrustbot assigned davidtwco and unassigned cjgillotJun 22, 2023
@bors

This comment was marked as resolved.

Sign in to view
@He1pa
He1paforce-pushed the translation_builtin_macros branch from ba2f003 to 3f8c7deCompareJune 24, 2023 16:42
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@He1pa
He1paforce-pushed the translation_builtin_macros branch from 3f8c7de to 8af8a95CompareJune 24, 2023 17:32
davidtwco
davidtwco approved these changes Jun 27, 2023
View reviewed changes

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me after fixing this typo.

Comment threadcompiler/rustc_builtin_macros/src/errors.rs Outdated
@davidtwcodavidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2023
@He1pa

He1pa commented Jun 28, 2023

Copy link
Copy Markdown
ContributorAuthor

@rustbot review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2023
@davidtwco

davidtwco commented Jun 28, 2023

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 28, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 453603a has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 29, 2023
@matthiaskrgr
Rollup merge ofrust-lang#112795- He1pa:translation_builtin_macros, …
fe2cdfb
…r=davidtwco
Migrate some rustc_builtin_macros to SessionDiagnostic
Part of rust-lang#100717.
`@rustbot` label +A-translation
@matthiaskrgrmatthiaskrgr mentioned this pull request Jun 29, 2023
Closed
@matthiaskrgrmatthiaskrgr mentioned this pull request Jun 29, 2023
Merged
@compiler-errorscompiler-errors mentioned this pull request Jun 30, 2023
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 30, 2023
@compiler-errors
Rollup merge ofrust-lang#112795- He1pa:translation_builtin_macros, …
ae30e8c
…r=davidtwco
Migrate some rustc_builtin_macros to SessionDiagnostic
Part of rust-lang#100717.
```@rustbot``` label +A-translation
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2023
@bors
Auto merge ofrust-lang#113162- matthiaskrgr:rollup-fct3wj7, r=matth…
97279e9
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#111322 (Support for native WASM exceptions)
- rust-lang#112086 (resolve: Remove artificial import ambiguity errors)
- rust-lang#112234 (refactor `tool_doc!`)
- rust-lang#112300 (Convert `run-make/coverage-reports` tests to use a custom compiletest mode)
- rust-lang#112795 (Migrate some rustc_builtin_macros to SessionDiagnostic)
- rust-lang#113144 (Make the `Elaboratable` trait take clauses)
- rust-lang#113161 (Fix type privacy lints error message)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit f135815 into rust-lang:masterJun 30, 2023
@rustbotrustbot added this to the 1.72.0 milestone Jun 30, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes

Assignees

@davidtwcodavidtwco

Labels

A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.72.0

Development

Successfully merging this pull request may close these issues.

6 participants

@He1pa@rustbot@rust-log-analyzer@cjgillot@bors@davidtwco