Uh oh!
There was an error while loading. Please reload this page.
Support interpolated block for try and async - #112953
Merged
Merged
Conversation
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm putting this up for T-lang discussion, to decide whether or not they feel like this should be supported. This was raised in #112952, which surprised me. There doesn't seem to be a technical reason why we don't support this.
Precedent:
This is supported:
Counterpoint:
However, for context, this is not supported:
If this support for
asyncandtrywith interpolated blocks is not desirable, then I can convert them to instead the same diagnostic asunsafe $blockand make this situation a lot less ambiguous.I'll try to write up more before T-lang triage on Tuesday. I couldn't find anything other than #69760 for why something like
unsafe $blockis not supported, and even that PR doesn't have much information.Fixes#112952