Remove `mips*-unknown-linux-gnu*` builders by workingjubilee · Pull Request #113274 · rust-lang/rust

workingjubilee · 2023-07-03T04:10:57Z

Pursuant to the current consensus in rust-lang/compiler-team#648

rustbot · 2023-07-03T04:11:03Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

workingjubilee · 2023-07-03T04:11:39Z

...of course I forget to r? @ghost

rustbot · 2023-07-03T04:11:41Z

Failed to set assignee to ghost: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

tgross35 · 2023-07-03T04:23:31Z

(asking for my own curiosity, not really suggesting anything) is there a need to remove all the dist-mips folders? It seems likely enough that they may be reenabled at some point, so maybe worth keeping them in tree with history and all? Or moved to a different directory if some tool automatically looks for the dist-x dirs

Noratrieb · 2023-07-03T04:36:59Z

git preserves all history, if one needs to be a git historian.

workingjubilee · 2023-07-03T05:07:17Z

Given that commits can also be easily reverted, I have received a recommendation that we should in fact remove these builders immediately, rather than waiting, as the burden has made it so essentially every PR merged lately has had one bors retry (...averaged). Which is fine by me, assuming that I did this correctly and everyone's on board. I will remove the "formally change the platform support page" commit to another PR.

klensy · 2023-07-03T10:43:47Z

But there some folder with promising name https://github.com/rust-lang/rust/tree/master/src/ci/docker/host-x86_64/disabled

nikic · 2023-07-03T19:52:22Z

I don't think this should touch anything more than the CI configuration.

workingjubilee · 2023-07-04T04:06:26Z

So just 634f952 ?

jyn514 · 2023-07-04T17:42:06Z

https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/Drop.20MIPS.20to.20tier.203.20compiler-team.23648/near/372165737:

I think an easy workaround is to land now, and revert on (future) beta. We can get past the bugs with a couple retries on the beta + stable compiler builds, but this fixes most folks builds now.

@bors r+ p=50 rollup=never

bors · 2023-07-04T17:42:10Z

📌 Commit 634f952 has been approved by jyn514

It is now in the queue for this repository.

bors · 2023-07-04T17:44:45Z

⌛ Testing commit 634f952 with merge 2c2f5cf020a890a48e8b4ff87ccad8cfdf118be1...

compiler-errors · 2023-07-04T18:55:29Z

@bors ping

bors · 2023-07-04T18:55:31Z

😪 I'm awake I'm awake

compiler-errors · 2023-07-04T18:55:55Z

@bors treeclosed=100 the tree is fucked up because of a raced try-build and auto merge in #113213

compiler-errors · 2023-07-04T19:03:48Z

gonna bump this auto build out of the queue, hope that's the right step here to make sure things don't get worse :(

@bors retry

compiler-errors · 2023-07-04T19:04:47Z

(haha, bors probably wouldn't have even merged 634f952 because it's not a fast forward.)

compiler-errors · 2023-07-04T19:11:04Z

@bors p=50
@bors retry

^^

workingjubilee · 2023-07-04T19:11:09Z

@bors r- p=50

compiler-errors · 2023-07-04T19:16:57Z

I think this can resume build now, thanks @Mark-Simulacrum for fixing the tree.

@bors r=jyn514
@bors treeclosed-

bors · 2023-07-04T19:16:58Z

📌 Commit 634f952 has been approved by jyn514

It is now in the queue for this repository.

bors · 2023-07-04T19:16:59Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors · 2023-07-04T19:17:08Z

⌛ Testing commit 634f952 with merge 9e4e584...

compiler-errors · 2023-07-04T19:17:37Z

The merge looks correct

rust-log-analyzer · 2023-07-04T19:18:06Z

The job armhf-gnu failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

curl: (22) The requested URL returned error: 404 error: failed to download llvm from ci
help: old builds get deleted after a certain time
help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml:
[llvm]
download-ci-llvm = false
Build completed unsuccessfully in 0:00:00

compiler-errors · 2023-07-04T19:18:27Z

Or not?

compiler-errors · 2023-07-04T19:21:19Z

Actually, that looks like a previous auto-merge, not this one.

#113274 (comment)

workingjubilee · 2023-07-04T19:26:49Z

should this retry then?

compiler-errors · 2023-07-04T19:27:26Z

No need -- it's merging successfully in https://github.com/rust-lang-ci/rust/actions/runs/5457834781

workingjubilee · 2023-07-04T19:28:23Z

Weird.

bors · 2023-07-04T21:33:19Z

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 9e4e584 to master...

rust-timer · 2023-07-04T22:48:50Z

Finished benchmarking commit (9e4e584): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 653.659s -> 653.846s (0.03%)

Update docs for mips target tier demotion. These mips targets were demoted in rust-lang#113274, but the documentation was not updated. I have also elected to document this in the release notes for 1.72 because I think that should have been included.

Rollup merge of rust-lang#116503 - ehuss:fix-mips-tier, r=Amanieu Update docs for mips target tier demotion. These mips targets were demoted in rust-lang#113274, but the documentation was not updated. I have also elected to document this in the release notes for 1.72 because I think that should have been included.

rustbot assigned Mark-Simulacrum Jul 3, 2023

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 3, 2023

Remove MIPS host CI workflows
634f952

workingjubilee force-pushed the demote-mips branch from 2384012 to 41a8376Compare July 3, 2023 05:07

workingjubilee changed the title ~~Demote mips*-unknown-linux-gnu* to tier 3~~Remove mips*-unknown-linux-gnu* buildersJul 3, 2023

workingjubilee marked this pull request as ready for review July 3, 2023 07:37

workingjubilee force-pushed the demote-mips branch from 41a8376 to 634f952Compare July 4, 2023 04:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2023

jyn514 mentioned this pull request Jul 4, 2023
Replace mk_const with Const::new_x methods #113325
Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 4, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 4, 2023

bors merged commit 9e4e584 into rust-lang:masterJul 4, 2023

rustbot added this to the 1.72.0 milestone Jul 4, 2023

workingjubilee deleted the demote-mips branch July 5, 2023 00:51

workingjubilee mentioned this pull request Jul 16, 2023
"Legacy" tier 2 targets have misplaced or absent maintainer docs #113739
Open
57 tasks

zachs18 mentioned this pull request Jul 17, 2023
Zeroable derive custom bounds Lokathor/bytemuck#196
Merged

CryZe mentioned this pull request Aug 24, 2023
Tracking Issue for Aarch64 Images cross-rs/cross#975
Open

ehuss mentioned this pull request Oct 7, 2023
Update docs for mips target tier demotion. #116503
Merged

Uh oh!

Uh oh!

Conversation

workingjubilee commented Jul 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 3, 2023

Uh oh!

workingjubilee commented Jul 3, 2023

Uh oh!

rustbot commented Jul 3, 2023

Uh oh!

tgross35 commented Jul 3, 2023

Uh oh!

Noratrieb commented Jul 3, 2023

Uh oh!

workingjubilee commented Jul 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

klensy commented Jul 3, 2023

Uh oh!

nikic commented Jul 3, 2023

Uh oh!

workingjubilee commented Jul 4, 2023

Uh oh!

jyn514 commented Jul 4, 2023

Uh oh!

bors commented Jul 4, 2023

Uh oh!

bors commented Jul 4, 2023

Uh oh!

compiler-errors commented Jul 4, 2023

Uh oh!

bors commented Jul 4, 2023

Uh oh!

compiler-errors commented Jul 4, 2023

Uh oh!

compiler-errors commented Jul 4, 2023

Uh oh!

compiler-errors commented Jul 4, 2023

Uh oh!

compiler-errors commented Jul 4, 2023

Uh oh!

workingjubilee commented Jul 4, 2023

Uh oh!

compiler-errors commented Jul 4, 2023

Uh oh!

bors commented Jul 4, 2023

Uh oh!

bors commented Jul 4, 2023

Uh oh!

bors commented Jul 4, 2023

Uh oh!

compiler-errors commented Jul 4, 2023

Uh oh!

rust-log-analyzer commented Jul 4, 2023

Uh oh!

compiler-errors commented Jul 4, 2023

Uh oh!

compiler-errors commented Jul 4, 2023

Uh oh!

workingjubilee commented Jul 4, 2023

Uh oh!

compiler-errors commented Jul 4, 2023

Uh oh!

workingjubilee commented Jul 4, 2023

Uh oh!

bors commented Jul 4, 2023

Uh oh!

rust-timer commented Jul 4, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

workingjubilee commented Jul 3, 2023•
edited
Loading

workingjubilee commented Jul 3, 2023•
edited
Loading