Skip to content

Improve documentation on when signes are printed by default - #115487

Merged
bors merged 1 commit into
rust-lang:masterfrom
ModProg:patch-1
Sep 16, 2023
Merged

Improve documentation on when signes are printed by default#115487
bors merged 1 commit into
rust-lang:masterfrom
ModProg:patch-1

Conversation

@ModProg

Copy link
Copy Markdown
Contributor

I found the original formulation a bit irritating, but not sure if I really improved it.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 2, 2023

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Sep 16, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit f479538 has been approved by dtolnay

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2023
@dtolnaydtolnay assigned dtolnay and unassigned joshtriplettSep 16, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2023
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#115247 (Document std limitations before/after main)
- rust-lang#115329 (fix std::primitive doc: homogenous -> homogeneous)
- rust-lang#115487 (Improve documentation on when signes are printed by default)
- rust-lang#115560 (Update doc for `alloc::format!` and `core::concat!`)
- rust-lang#115836 (update rust_analyzer_settings.json)
- rust-lang#115884 (make ty::Const debug printing less verbose)
- rust-lang#115890 (Migrate GUI colors test to original CSS color format)
- rust-lang#115895 (Improve Vec(Deque)::truncate documentation)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b8c4b78 into rust-lang:masterSep 16, 2023
@rustbotrustbot added this to the 1.74.0 milestone Sep 16, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2023
Rollup merge of rust-lang#115487 - ModProg:patch-1, r=dtolnay
Improve documentation on when signes are printed by default
I found the original formulation a bit irritating, but not sure if I really improved it.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ModProg@rustbot@dtolnay@bors@joshtriplett