Uh oh!
There was an error while loading. Please reload this page.
adjust how closure/generator types are printed - #115696
Conversation
rustbot
commented
Sep 9, 2023
(rustbot has picked a reviewer for you, use r? to override) |
Hm, something somewhere is still printing |
RalfJung
commented
Sep 9, 2023
Ah, what I changed was actually the rvalue printing (which doesn't seem to be exercised by the test suite), not the type printing. |
d9d80be to
2771839Comparerustbot
commented
Sep 9, 2023
The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
2771839 to
411e645Compareoli-obk
commented
Sep 11, 2023
Seems fine to me, please create an MCP for it so all of the compiler team gets informed about it. |
bors
commented
Sep 11, 2023
☔ The latest upstream changes (presumably #115661) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
commented
Sep 16, 2023
@oli-obk how long do we want to wait from the MCP seconding to landing the PR? |
411e645 to
aa50cdeCompareoli-obk
commented
Sep 17, 2023
MCPs are 10 days |
bors
commented
Sep 19, 2023
☔ The latest upstream changes (presumably #115865) made this pull request unmergeable. Please resolve the merge conflicts. |
BoxyUwU
commented
Sep 21, 2023
the MCP has been accepted for 10 days now this can be merged after a rebase presumably |
aa50cde to
c4ec12fCompareoli-obk
commented
Sep 22, 2023
@bors r+ |
bors
commented
Sep 22, 2023
bors
commented
Sep 22, 2023
bors
commented
Sep 22, 2023
☀️ Test successful - checks-actions |
rust-timer
commented
Sep 22, 2023
Finished benchmarking commit (959b2c7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 633.528s -> 635.567s (0.32%) |
adjust how closure/generator types are printed I saw `&[closure@$DIR/issue-20862.rs:2:5]` and I thought it is a slice type, because that's usually what `&[_]` is... it took me a while to realize that this is just a confusing printer and actually there's no slice. Let's use something that cannot be mistaken for a regular type.
I saw
&[closure@$DIR/issue-20862.rs:2:5]and I thought it is a slice type, because that's usually what&[_]is... it took me a while to realize that this is just a confusing printer and actually there's no slice. Let's use something that cannot be mistaken for a regular type.